Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Net Standard 2.0 only FSharp.Core #9801

Merged

Conversation

KevinRansom
Copy link
Member

The FSharp.Core nuget package will only ship netstandard2.0 binaries.

The binaries are fully compatible with net472, and netcoreapp2.0 and up.
For developers targeting earlier releases of the DotNET framework should use 4.7.2

It require some bug fixing to the test framework and simulated msbuildresolver.

@KevinRansom KevinRansom requested a review from brettfo July 27, 2020 09:58
@KevinRansom KevinRansom changed the title Net standard only FSharp.Core Net Standard 2.0 only FSharp.Core Jul 27, 2020
@KevinRansom
Copy link
Member Author

Bugger I guess I need to deal with the fcs build.

@KevinRansom KevinRansom force-pushed the removedesktopfsharpcore branch from 93af875 to e7cf6fb Compare July 29, 2020 06:51
@KevinRansom KevinRansom force-pushed the removedesktopfsharpcore branch from 10d2d04 to d25cac8 Compare July 29, 2020 21:18
@KevinRansom KevinRansom merged commit b6bbac9 into dotnet:release/dev16.8 Jul 30, 2020
vzarytovskii pushed a commit to vzarytovskii/fsharp that referenced this pull request Aug 4, 2020
* Net standard only FSharp.Core

* temp
KevinRansom added a commit that referenced this pull request Aug 6, 2020
…9870)

* Net Standard 2.0 only FSharp.Core (#9801)

* Net standard only FSharp.Core

* temp

* Cherry-pick of FSharp.Core netstandard + fix for netcoreapp3.1 tests

* Fixed netcoreapp30 -> netcoreapp31 test references

* Cleaned up projects, added testplatform package, moved some tests to new suite

* Tests changes

* Revert accidental revert

* Added missing tests

* Cleaned up packages, fixed tests

* Add System.Runtime to references

Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>
abelbraaksma pushed a commit to abelbraaksma/fsharp that referenced this pull request Aug 9, 2020
…otnet#9870)

* Net Standard 2.0 only FSharp.Core (dotnet#9801)

* Net standard only FSharp.Core

* temp

* Cherry-pick of FSharp.Core netstandard + fix for netcoreapp3.1 tests

* Fixed netcoreapp30 -> netcoreapp31 test references

* Cleaned up projects, added testplatform package, moved some tests to new suite

* Tests changes

* Revert accidental revert

* Added missing tests

* Cleaned up packages, fixed tests

* Add System.Runtime to references

Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>
@KevinRansom KevinRansom deleted the removedesktopfsharpcore branch August 19, 2020 20:21
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
…otnet#9870)

* Net Standard 2.0 only FSharp.Core (dotnet#9801)

* Net standard only FSharp.Core

* temp

* Cherry-pick of FSharp.Core netstandard + fix for netcoreapp3.1 tests

* Fixed netcoreapp30 -> netcoreapp31 test references

* Cleaned up projects, added testplatform package, moved some tests to new suite

* Tests changes

* Revert accidental revert

* Added missing tests

* Cleaned up packages, fixed tests

* Add System.Runtime to references

Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
* Net standard only FSharp.Core

* temp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants