Record names are not suggested in the pattern matching

[psfinaki]

This code:

type SomeType = { TheField : string }

let f x =
    match x with
    | { TheField = "A" } -> true
    | {  = "B" } -> true
    | _ -> false

... doesn't suggest TheField for the pattern matching rule at any time.

bug2.mp4

I am quite sure this is a bug and a regression. This is implied by this bug and by common sense.

[kerams]

I'll fix this.

[nojaf]

I noticed the AST is also rather lacking https://fsprojects.github.io/fantomas-tools/#/ast?data=N4KABGBEAmCmBmBLAdrAzpAXFSAacUiaAYmolmPAIYA2as%2BEkAxgPZwWQAuAngA6wwAZVYBbWABV%2BggLxhgYCQAtYxRLBrQw2NFwBOKAOZgAvgB09Z5Bas1YXSmAAeYGTeQQIoql2ZLnYADuiFxK7p5gAD7yiipqGlpyZpAAgsmmYAC0AHxg%2BgCusOGe0QquYMkAQukmWbkFRZYeJWAA%2BnWUtPR4BJCwTnxUyNAUDSAmQA

I don't think there is any proper recovery for the { = "B" } pattern.

fsharp/src/Compiler/SyntaxTree/SyntaxTree.fsi

Line 1107 in 97a5b65

| Record of fieldPats: ((LongIdent * Ident) * range * SynPat) list * range: range

That most likely also needs addressing.

[kerams]

I'll fix this.

Actually, I don't think I broke it in my completions PRs. Are we positive this worked in 17.7 or earlier? There's nevertheless certainly room for improvement in terms of filtering, adding field names and suggesting pattern names to the right of =.

[psfinaki]

Well the demo is on VS GA, 17.7.2.
I mean, I don't know if this got broken recently but I would be very surprised if it turns out that this never worked / is by design. :)

[kerams]

I wouldn't - specialized completions for patterns were non-existent just a couple of weeks ago. We only have a completion context for record expressions, which results in field names being inserted into the completions list.

[0101]

It's the same in 17.6.6.

[psfinaki]

Hmhm alright, I'll remove the regression tag then for now.
Nevertheless - it would be definitely a useful addition.