Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReplaceWithSuggestion code fix doesn't fix FS1129 #15887

Closed
Tracked by #15408
psfinaki opened this issue Aug 28, 2023 · 1 comment · Fixed by #16020
Closed
Tracked by #15408

ReplaceWithSuggestion code fix doesn't fix FS1129 #15887

psfinaki opened this issue Aug 28, 2023 · 1 comment · Fixed by #16020
Labels
Area-LangService-CodeFixes Code fixes associated with diagnostics Bug Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code.

Comments

@psfinaki
Copy link
Member

This code:

type SomeType = { TheField : string }

let test = { TheField = "X" }

let f x =
    match x with
    | { TheField = "A" } -> true
    | { TheFiedl = "B" } -> true
    | _ -> false

...triggers the code fix for the first case but doesn't trigger it for the second one.

bug1.mp4
@psfinaki
Copy link
Member Author

psfinaki commented Aug 28, 2023

Blocked by #15889. We just don't get this suggestion to anyhow process it.

@0101 0101 added Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code. and removed Needs-Triage labels Sep 4, 2023
@psfinaki psfinaki modified the milestones: Backlog, September-2023 Sep 27, 2023
@github-project-automation github-project-automation bot moved this from Not Planned to Done in F# Compiler and Tooling Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-LangService-CodeFixes Code fixes associated with diagnostics Bug Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants