Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenabling ReplaceWithSuggestion for FS1129 #16020

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Conversation

psfinaki
Copy link
Member

@psfinaki psfinaki commented Sep 22, 2023

Closes #15887

This just started working after this fix.
Hence just readding the diag removed in this PR and the corresponding test.

@psfinaki psfinaki requested a review from a team as a code owner September 22, 2023 12:25
@psfinaki
Copy link
Member Author

/azp ru

@psfinaki
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Command 'ru' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@abonie abonie merged commit afa5809 into dotnet:main Oct 4, 2023
25 checks passed
@psfinaki psfinaki deleted the codefixes-41 branch October 4, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

ReplaceWithSuggestion code fix doesn't fix FS1129
4 participants