Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestions for mispelled values are not applied against simple values. #1909

Closed
isaacabraham opened this issue Dec 1, 2016 · 7 comments
Closed

Suggestions for mispelled values are not applied against simple values. #1909

isaacabraham opened this issue Dec 1, 2016 · 7 comments

Comments

@isaacabraham
Copy link
Contributor

The following code provides a valid suggestion: -

type Foo = { Name : string }
let bar = { Nam = "Isaac" }

However the following does not: -

let name = "Isaac"
let fullName = nam + " Abraham"

I would like the compiler to apply the same suggestions whenever any symbols cannot be identified.
@isaacabraham
Copy link
Contributor Author

cc: @forki

@forki
Copy link
Contributor

forki commented Dec 1, 2016

I'm on it

@forki
Copy link
Contributor

forki commented Dec 1, 2016

image

@forki
Copy link
Contributor

forki commented Dec 1, 2016

^^ this is without jaro-winkler...

forki added a commit to forki/visualfsharp that referenced this issue Dec 1, 2016
@forki
Suggestions for mispelled values - fixes dotnet#1909
a3fb23b
@forki
Copy link
Contributor

forki commented Dec 1, 2016

see #1911

@isaacabraham
Copy link
Contributor Author

Wicked. Nice one.

@forki
Copy link
Contributor

forki commented Dec 1, 2016

We could filter even better if we would have type information, but hey I think it's still progress

forki added a commit to forki/visualfsharp that referenced this issue Dec 2, 2016
@forki
Suggestions for mispelled values - fixes dotnet#1909
797e553
forki added a commit to forki/visualfsharp that referenced this issue Dec 2, 2016
@forki
Suggestions for mispelled values - fixes dotnet#1909
dd1b41d
forki added a commit to forki/visualfsharp that referenced this issue Dec 2, 2016
@forki
Suggestions for mispelled values - fixes dotnet#1909
cddec5a
forki added a commit to forki/visualfsharp that referenced this issue Dec 2, 2016
@forki
Suggestions for mispelled values, namespaces and co - fixes dotnet#1909
62f822e
forki added a commit to forki/visualfsharp that referenced this issue Dec 2, 2016
@forki
Suggestions for mispelled values, namespaces and co - fixes dotnet#1909
8acc0f5
forki added a commit to forki/visualfsharp that referenced this issue Dec 3, 2016
@forki
Suggestions for mispelled values, namespaces and co - fixes dotnet#1909
06e0eba
forki added a commit to forki/visualfsharp that referenced this issue Dec 3, 2016
@forki
Suggestions for mispelled values, namespaces and co - fixes dotnet#1909
1c33df2
forki added a commit to forki/visualfsharp that referenced this issue Dec 3, 2016
@forki
Suggestions for mispelled values, namespaces and co - fixes dotnet#1909
577352f
forki added a commit to forki/visualfsharp that referenced this issue Dec 4, 2016
@forki
Suggestions for mispelled values, namespaces and co - fixes dotnet#1909
d31c279
forki added a commit to forki/visualfsharp that referenced this issue Dec 4, 2016
@forki
Suggestions for mispelled values, namespaces and co - fixes dotnet#1909
b953a78
forki added a commit to forki/visualfsharp that referenced this issue Dec 5, 2016
@forki
Suggestions for mispelled values, namespaces and co - fixes dotnet#1909
ca0bf1f
forki added a commit to forki/visualfsharp that referenced this issue Dec 6, 2016
@forki
Suggestions for mispelled values, namespaces and co - fixes dotnet#1909
a636ec7
forki added a commit to forki/visualfsharp that referenced this issue Dec 7, 2016
@forki
Suggestions for mispelled values, namespaces and co - fixes dotnet#1909
3007097
forki added a commit to forki/visualfsharp that referenced this issue Dec 7, 2016
@forki
Suggestions for mispelled values, namespaces and co - fixes dotnet#1909
72d2024
forki added a commit to forki/visualfsharp that referenced this issue Dec 10, 2016
@forki
Suggestions for mispelled values, namespaces and co - fixes dotnet#1909
5ee6ddd
forki added a commit to forki/visualfsharp that referenced this issue Dec 14, 2016
@forki
Suggestions for mispelled values, namespaces and co - fixes dotnet#1909
28c89d7
forki added a commit to forki/visualfsharp that referenced this issue Dec 14, 2016
@forki
Suggestions for mispelled values, namespaces and co - fixes dotnet#1909
39a9627
forki added a commit to forki/visualfsharp that referenced this issue Dec 15, 2016
@forki
Suggestions for mispelled values, namespaces and co - fixes dotnet#1909
1559b02
forki added a commit to forki/visualfsharp that referenced this issue Dec 15, 2016
@forki
Suggestions for mispelled values, namespaces and co - fixes dotnet#1909
e308942
forki added a commit to forki/visualfsharp that referenced this issue Dec 16, 2016
@forki
Suggestions for mispelled values, namespaces and co - fixes dotnet#1909
58baf51
forki added a commit to forki/visualfsharp that referenced this issue Dec 16, 2016
@forki
Suggestions for mispelled values, namespaces and co - fixes dotnet#1909
7f93721
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@forki @isaacabraham