Support modern MSBuild 15 like fsproj

[forki]

I have a project with MSBuild 15 see
https://github.com/fable-compiler/fable-suave-scaffold/blob/master/src/Server/Server.fsproj and works perfectly in ionide. Visual Studio 2017 RC says it is not supported.

@cartermp @KevinRansom @enricosada what's the plan for this?

[KevinRansom]

@forki -- the dotnet sdk team are creating templates for F# VS and coreclr.

[forki]

We don't need templates. We need vs to load fsproj - or what am I missing? Am 24.01.2017 8:14 nachm. schrieb "Kevin Ransom (msft)" < notifications@github.com>:

…

@forki <https://github.com/forki> -- the dotnet sdk team are creating templates for F# VS and coreclr. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2316 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADgNHXdVdtC4HLBpM6O8GhYedoG4WZCks5rVk14gaJpZM4LskAL> .

[forki]

FTR: my sample project has absolutely valid fsproj according to dotnetcore and MSBuild. It works absolutely nice with paket integration and ionide understands everything correctly.
TBH we currently push a similar thing to azure about 5 to 10 times a day.

[KevinRansom]

Sounds great ... looks like it's using the new dotnet SDK ... perhaps you can chat with them about what is missing ...

@enricosada might also be able to point you in the right direction.

[forki]

who is them?

[cartermp]

@KevinRansom just to clarify the scenario:

1. I create an MSBuild15-based F# project with the .NET CLI.
2. I attempt to open this project in Visual Studio
3. It fails, because we do not recognize MSBuild15 fsprojs

I'm not sure this is a CLI or SDK concern; I think this is squarely our problem to solve. As it stands, there is no way to open an F# project using the MSBuild15 fsproj in VS 2017. This is a bad situation because it means that you're locked out of anything .NET Core or .NET Standard for F# in VS 2017. This is what I get on the build with Brett's insertion:

[forki]

Thanks @cartermp - started to completely question myself.

[forki]

I think the generated fsproj is fine dotnetcli is doing the right thing thanks to @enricosada. It's "just" VS is rejecting it. So it's definitely a VF# concern.

[KevinRansom]

@cartermp @forki,

Visual Studio is apparently not yet shipping with an SDK that installs enrico's sdk additions. I am looking at a build from the latest rtm branch.

I will follow up with the DOTNET SDK team directly, or someone can follow up with them on the dotnet cli repo. Piotr is in a one on one and then shiproom right now otherwise I would have a definitive answer.

Kevin

[enricosada]

@KevinRansom preview4 already works, What's needed always ship with sdk, after preview3 are just enhancement and cleanups. Also preview3 was working.
See my PR #2250 there there is also an example https://github.com/enricosada/visualfsharp/blob/use_net_core_sdk/examples/dotnetcoresdk/simple/console/ConsoleApp.fsproj who use FscTask too instead of dotnet-compile-fsc

AFAIK vs should

• use Roslyn-project-system so we get all vs ui stuff (treeview etc)
• I think we should add an FSharp capability (I can add that in the sdk target files, so is added for every fsproj, like the other props), that add the and initialize the languageservice parsing the compiler args from fsproj (similar on how now works) so intellisense works.

How vscode works now? How can have intellisense? On build a compile-fsc.rsp is generated who is the response file use for fsc, and ionide read that to initialize the FCS.
Now we can use FscTask (my pr) so compiler args gathering should change a bit (no response file).

If you want to try latest version with preview4, see my pr.

[enricosada]

@KevinRansom what sdk version is used? Becuase fsproj works with all msbuild based preview3,4 and new rc.
Based on sdk version I can give you right templates (or just do dotnet new).

If we know a valid c# template is also easy to modify to be an f# one, changes are minimal.

I hope to have an installed VS2017 RC soon, to try it.

[KevinRansom]

@ enrico so ...
C# is not helpful in this case, because it is supported in the box. I know that they intend to ship your modifications in the box, which will make this template fine. However ... it's not there yet.

Moving the project system to CPS should now be orthogonal. The "joy" of moving back to msbuild based projects means that our current project system should work reasonably well.

As I said I will chat with Piotr and find out why your stuff didn't yet ship. And see if there are some modifications we can propose to the templates.

Kevin

[enricosada]

@KevinRansom about c# I mean seeing the template can show what version of f# template use. In Preview3 for example The f# is just an additional normal PackageReference, so nothing ship with sdk.
Anyway easier wait Piotr

About cps/Roslyn yes is orthogonal, but maybe we can start work on that on master branch, more work becuase need to be implemented, but less work to adapt current code to msbuild.
For example current project system reorder fsproj items on save, no multi fw support, reference but no PackageReference etc.
with Roslyn workspaces already implemented we have a good starting point. Lots of possible PR :)

[KevinRansom]

@enricosada

It seems to me that Goal 1 should be that VS can load a dotnet/cli fsharp template so that we can edit the source. Since we are now using msbuild that should not be too bad a problem to solve.

Most of the project file editing would not have UI because we aren't yet on CPS but we should be able to add --- move, rename and remove F# source files. References will be problematic because they are quite different now and moving to CPS will help address that.

It seems that we are not at Goal 1 - Piotr on DotnetCLI and Daniel on the MSBuild team tells me that your SDK project is included in box for dotnet cli, but not included inbox for VS.

However, we should be able to author an F# template that doesn't use the SDK wiring which can be loaded into the F# Project System as is. For sure the current templates do not do so.