Add "Install package" code fix

[vasily-kirichenko]

We could steal / use packages indexing logic from Roslyn sources.

[forki]

Noooo. Please please please please let's not repeat that epic mistake. It will make dependency management even harder

[vasily-kirichenko]

Why? It would use Paket of course, respect paket.references for the current project, etc. What's the problem?..

[forki]

If the stuff is in lock file then fine. But things like R# are AFAIK referencing stuff from nuget.org and just putting that package into your app. That's madness. Am 18.04.2017 11:55 vorm. schrieb "Vasily Kirichenko" < notifications@github.com>:

…

Why? It would use Paket of course, respect paket.references for the current project, etc. What's the problem?.. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2873 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADgNDggOu9gLUeBmeJVo1BPw4o0HVkyks5rxIh4gaJpZM4NAGou> .

[vasily-kirichenko]

Ah, no. If we will implement it, we implement it so that you and Paket are happy :)

[cartermp]

cc @CyrusNajmabadi, who built this feature in VS 2017 (not to be confused with the feature in vs2015 for xproj only which was coupled to NuGet and wasn't very flexible)

There were some reasons why this was turned off by default for C#, part of which came down to needing to drop a new typeforwarding .dll. If this were to be built, and the C# feature turned on, then we'd have two on-launch downloads of a compressed database of symbols, two typeforwarding .dlls, and two mechanisms by which packages get added this way. Not ideal, and may end up suffering the scrutiny of VS shiproom.

I believe what was built depends on ISymbol based on quickly browsing the source. That may mean it's very difficult for us to use, if not impossible. Perhaps work could be contributed in Roslyn to make it usable by F#? I think the best approach is the following:

1. Work to make the existing feature usable by F#
2. Work to allow the existing feature to use Paket instead of NuGet if that's what the user would prefer

I don't know what either of those looks like, but I would guess it's a fair bit of work. Would love to see this in the IDE for F#, though.

[CyrusNajmabadi]

@cartermp

There were some reasons why this was turned off by default for C#, part of which came down to needing to drop a new typeforwarding .dll.

I don't know what you're referring to.

--

Roslyn could certainly expose the API to get at the index information. Currently that exists in: https://github.com/dotnet/roslyn/blob/master/src/Workspaces/Core/Portable/SymbolSearch/ISymbolSearchService.cs

Making that avialable to F# definitely seems doable. It will still be up to you guys to hook it up to a lightbulb and to do whatever necessary when you actually invoke the lightbulb.

[vasily-kirichenko]

@CyrusNajmabadi Yes, we need the index only. So we can import ISymbolSearchService and use it?

[CyrusNajmabadi]

right now it's internal. do you have IVT? Note: we reserve the right to change this interface at any time. :)

[vasily-kirichenko]

@CyrusNajmabadi we don't http://source.roslyn.io/#Microsoft.CodeAnalysis.Workspaces/GeneratedInternalsVisibleTo.cs :(((

We want to :) Is it possible to add FSharp.Editor assembly there?

[CyrusNajmabadi]

I currently doubt it :) IVTs are a super high burden for us. They effectively open the door for any change becoming one that can break you.

Better would be a request for us to expose the ISymbolSearchService.

[forki]

No. Really. Please don't activate that feature. It's just wrong. Am 18.04.2017 6:00 nachm. schrieb "Phillip Carter" <notifications@github.com

…

: cc @CyrusNajmabadi <https://github.com/CyrusNajmabadi>, who built this feature for C# There were some reasons why this was turned off by default for C#, part of which came down to needing to drop a new typeforwarding .dll. If this were to be built, and the C# feature turned on, then we'd have two on-launch downloads of a compressed database of symbols, two typeforwarding .dlls, and two mechanisms by which packages get added this way. Not ideal, and may end up suffering the scrutiny of VS shiproom. I believe what was built depends on ISymbol based on quickly browsing the source. That may mean it's very difficult for us to use, if not impossible. Perhaps work could be contributed in Roslyn to make it usable by F#? I think the best approach is the following: 1. Work to make the existing feature usable by F# 2. Work to allow the existing feature to use Paket instead of NuGet if that's what the user would prefer I don't know what either of those looks like, but I would guess it's a fair bit of work. Would love to see this in the IDE for F#, though. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2873 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADgNGL4k_Z5sLZlMxYKgOSr1Nt5IF-gks5rxN4NgaJpZM4NAGou> .

[vasily-kirichenko]

@forki what's wrong with it?