Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All features stop working on opened script files after project reloading #2916

Closed
vasily-kirichenko opened this issue Apr 25, 2017 · 4 comments
Closed

All features stop working on opened script files after project reloading #2916

vasily-kirichenko opened this issue Apr 25, 2017 · 4 comments
Labels
Area-LangService-API Bug Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code. Regression
Milestone
15.3

Comments

@vasily-kirichenko
Copy link
Contributor

1
@saul
Copy link
Contributor

saul commented Apr 25, 2017

Think this is related to #1944 - I'm working on a fix now

@saul saul mentioned this issue Apr 25, 2017
Closed
6 tasks
saul added a commit to saul/fsharp that referenced this issue Apr 25, 2017
@saul
Refactor single-file script loading, fix Roslyn workspace syncronisat…
eedfcea 
…ion (add support changing project references)

Fixes dotnet#2916, fixes dotnet#1944
@dsyme dsyme added Area-LangService-API Bug Regression Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code. labels Apr 29, 2017
@cartermp cartermp added this to the VS 2017 Updates milestone Apr 29, 2017
@dsyme
Copy link
Contributor

dsyme commented May 11, 2017

I believe this is fixed by #3025, at least for the cases I've been looking at

There may be additional cases such as renames and others not covered by that, where we need to listen to RDT

@vasily-kirichenko
Copy link
Contributor Author

I confirm it's fixed in #3025. Thanks!

@dsyme dsyme mentioned this issue May 16, 2017
Merged
2 tasks
@dsyme
Copy link
Contributor

dsyme commented May 16, 2017

Fixed by #3025

@dsyme dsyme closed this as completed May 16, 2017
@cartermp cartermp modified the milestones: VS 2017 Updates, 15.3 Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-LangService-API Bug Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code. Regression
Projects
None yet
Milestone
15.3
Development

Successfully merging a pull request may close this issue.

[WIP] Improve solution load performance saul/fsharp
4 participants
@saul @vasily-kirichenko @cartermp @dsyme