Make Type Provider troubleshooting easier with better error reporting

[smoothdeveloper]

Can we consider replacing e.Message with string e at this location where we report exceptions happening at design time.

https://github.com/Microsoft/visualfsharp/blob/cea9284349e6ecc803cc39b67096b83010f0416d/src/fsharp/tainted.fs#L103

The exception details would be valuable in troubleshooting issues in type providers.

[dsyme]

@smoothdeveloper Yes, we can. Please submit a PR for it including updating test cases.

[smoothdeveloper]

Ok thanks.

The error will look scary, but it will definitely help troubleshooting.

[dsyme]

@smoothdeveloper We'll need to think about this more - exceptions are how TPs currently raise diagnostics, and we can't attach stack traces to those diagnostics.

[smoothdeveloper]

@dsyme, sorry I somehow missed your comment.

Can you expand on the meaning of "we can't attach stack traces to those diagnostics"? Is it related to how VS tooling display the errors or some policy about errors?

The PR is calling ToString on the exception so we are technically not attaching a stack trace object and just providing a string, but you probably mean it shouldn't surface even in textual form.

[smoothdeveloper]

another issue: fsprojects/Rezoom.SQL#54