Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TcSymbolUseData array LOH allocations #7983

Closed
TIHan opened this issue Dec 16, 2019 · 1 comment · Fixed by #8027
Closed

TcSymbolUseData array LOH allocations #7983

TIHan opened this issue Dec 16, 2019 · 1 comment · Fixed by #8027
Labels
Area-LangService-API
Milestone
16.5

Comments

@TIHan
Copy link
Contributor

TIHan commented Dec 16, 2019

Untitled
Seems we still have some issues with TcSymbolUseData array, might be an easy fix.
@cartermp
Copy link
Contributor

Interesting. @baronfel implemented the chunking here: https://github.com/dotnet/fsharp/blob/master/src/absil/illib.fs#L439-L479

Should the chunk size be decreased? It's below 85k.

This was referenced Dec 16, 2019
Closed
Merged
@cartermp cartermp mentioned this issue Jan 17, 2020
Closed
5 tasks
@cartermp cartermp added this to the 16.5 milestone Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-LangService-API
Projects
None yet
Milestone
16.5
Development

Successfully merging a pull request may close this issue.

Set LOH threshold for chunked resizearray to be smaller to avoid LOH allocations cartermp/fsharp
2 participants
@TIHan @cartermp