Set LOH threshold for chunked resizearray to be smaller to avoid LOH allocations #8027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
commented
Dec 19, 2019
|
I think the only thing that should be changed here is the max chunk size, instead of 84_900, do 80_000. Roslyn does this for very large source text: http://sourceroslyn.io/#Microsoft.CodeAnalysis/Text/LargeText.cs,c126f77d711f5b91,references |
TIHan
approved these changes
Dec 22, 2019
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
…allocations (dotnet#8027) * Set LOH threshold for chunked resizearray to be smaller to avoid LOH allocations * Update illib.fs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7983