Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutable fields --- Fixes #10021 --- fsi 10.9.1.0 for F# 4.7 reference dll ok but 10.10.0.0 for F# 4.7 not ok #10116

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Mutable fields --- Fixes #10021 --- fsi 10.9.1.0 for F# 4.7 reference dll ok but 10.10.0.0 for F# 4.7 not ok #10116

merged 1 commit into from
Sep 14, 2020

Conversation

KevinRansom
Copy link
Member

@KevinRansom KevinRansom commented Sep 13, 2020 •
edited by dsyme
Loading

This is a bug caused by mutable state.

loader reqd.AssemblyName may cause the entry for reqd.AssemblyName to be fixed up, if the reference was provided using --reference.

So before we try to fix up the entry we re-check to see if the ccuthunk has already been fixed up.

Kevin

@cartermp cartermp linked an issue Sep 13, 2020 that may be closed by this pull request
fsi 10.9.1.0 for F# 4.7 reference dll ok but 10.10.0.0 for F# 4.7 not ok #10021
Closed
@dsyme dsyme changed the title Bloody mutable fields --- Fixes #10021 --- fsi 10.9.1.0 for F# 4.7 reference dll ok but 10.10.0.0 for F# 4.7 not ok Mutable fields --- Fixes #10021 --- fsi 10.9.1.0 for F# 4.7 reference dll ok but 10.10.0.0 for F# 4.7 not ok Sep 14, 2020
@cartermp cartermp merged commit c1b7e6a into dotnet:main Sep 14, 2020
KevinRansom added a commit that referenced this pull request Sep 14, 2020
@dotnet-bot @KevinRansom
Merge main to release/dev16.8 (#10120)
038fd2f 
* Bloody mutable fields (#10116)

* Fix 9150 --- #i nuget on desktop witout net48 ref assemblies fails. (#10114)

* signing (#10108)

Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>
@KevinRansom KevinRansom deleted the fix10021 branch October 29, 2020 18:57
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
@KevinRansom @nosami
Bloody mutable fields (dotnet#10116)
e457539
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
@dotnet-bot @KevinRansom @nosami
Merge main to release/dev16.8 (dotnet#10120)
2aafef7 
* Bloody mutable fields (dotnet#10116)

* Fix 9150 --- #i nuget on desktop witout net48 ref assemblies fails. (dotnet#10114)

* signing (dotnet#10108)

Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@cartermp cartermp cartermp approved these changes

@brettfo brettfo Awaiting requested review from brettfo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fsi 10.9.1.0 for F# 4.7 reference dll ok but 10.10.0.0 for F# 4.7 not ok
3 participants
@KevinRansom @vzarytovskii @cartermp