Correct IDE diagnostics and lifetimes for editing with #r package references #10160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
changed the title
cartermp
reviewed
Sep 19, 2020
added 2 commits
September 20, 2020 01:43
dsyme
changed the title
dsyme
changed the title
added 2 commits
September 20, 2020 03:28
|
Surface area needs update |
|
This looks good subject to CI passing. |
|
Note to self - tests needs adjusting |
added 2 commits
September 20, 2020 13:07
|
OK, the tests are adjusted for the diagnostics updates. |
cartermp
reviewed
Sep 20, 2020
tests/FSharp.Compiler.Private.Scripting.UnitTests/DependencyManagerInteractiveTests.fs
Show resolved
Hide resolved
|
OK, green and ready |
6 tasks
KevinRansom
approved these changes
Sep 20, 2020
| @@ -757,6 +761,9 @@ type internal FsiCommandLineOptions(fsi: FsiEvaluationSessionHostConfig, argv: s | |||
| stopProcessingRecovery e range0; failwithf "Error creating evaluation session: %A" e | |||
| inputFilesAcc | |||
|
|
|||
| // We need a dependency provider with native resolution. Managed resolution is handled by generated `#r` | |||
There was a problem hiding this comment.
I think this is slightly optimistic. But I don't know a scenario where this is a wrong statement. I'm guessing we'll find them.
cartermp
approved these changes
Sep 20, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
…erences (dotnet#10160) Co-authored-by: Don Syme <donsyme@fastmail.com>
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
…erences (dotnet#10160) Co-authored-by: Don Syme <donsyme@fastmail.com>
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
…erences (dotnet#10160) Co-authored-by: Don Syme <donsyme@fastmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends #10159 with some basic improvements to correct how and when we create DependencyProvider
Only create DependencyProvider once per project, and one overall for scripts
Don't register endless chains of dynamic resolution handlers for the compiler and IDE cases
Gives diagnostics and failures in the IDE
Gives diagnostics and failures in F# compilation of scripts
Gives diagnostics and failures in F# Interactive execuation of scripts
Give tooltips (this was a feature lost on VS2017 or VS2019 for #r references in scripts, and easy to resurrect and augment to give information for package references). Note how the text shows the exact package versions and DLLs caused by the reference
Note that script editing is still always .NET Framework in this release, sadly - there are obviously many scripts where this doesn't matter but it's something to be aware of - we will be able to correct this somehow in the next release, it's too important not to.