Skip to content

Use TargetFramework name to determine the kind of framework. #10247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cartermp merged 2 commits into from
Oct 12, 2020
Merged

Use TargetFramework name to determine the kind of framework. #10247

cartermp merged 2 commits into from
Oct 12, 2020

Conversation

@teo-tsirpanis
Copy link
Contributor

@teo-tsirpanis teo-tsirpanis commented Oct 12, 2020 •
edited
Loading

Fixes #10245.

I would especially appreciate if this PR was marked with a hacktoberfest-accepted label.

@saul
Copy link
Contributor

saul commented Oct 12, 2020

I believe this should be TargetFrameworkIdentifier?

saul
saul reviewed Oct 12, 2020
View reviewed changes
@teo-tsirpanis
Copy link
Contributor Author

teo-tsirpanis commented Oct 12, 2020

How does it look like now @saul and @sfoslund?

I used MSBuild's Choose and Otherwise elements. Any TargetFramework that does not start with net4 will fall to the second case.

saul
saul reviewed Oct 12, 2020
View reviewed changes
@teo-tsirpanis @saul
Use TargetFrameworkIdentifier in FSharp.Profiles.props.
e0c5ea1 
Co-authored-by: Saul Rennison <saul@users.noreply.github.com>
cartermp
cartermp approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think this looks good. Would like @brettfo to look at this as well though.

@brettfo
Copy link
Member

brettfo commented Oct 12, 2020

Yep, I'm good with it.

I've also added the requested label in an appropriately spooky orange.

@cartermp
Copy link
Contributor

cartermp commented Oct 12, 2020

And it's also fitting because mucking about with MSBuild files is always spooky.

@cartermp cartermp merged commit 62c2ae0 into dotnet:main Oct 12, 2020
@teo-tsirpanis teo-tsirpanis deleted the patch-1 branch October 12, 2020 22:35
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
@teo-tsirpanis @saul @nosami
Use TargetFramework name to determine the kind of framework. (dotnet#…
4601643 
…10247)

Co-authored-by: Saul Rennison <saul@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@saul saul saul left review comments

@sfoslund sfoslund sfoslund left review comments

@brettfo brettfo brettfo approved these changes

@cartermp cartermp cartermp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Audit TargetFramework usage for .NET 5 TFM change

5 participants

@teo-tsirpanis @saul @brettfo @cartermp @sfoslund