-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved nice print to give literal values #10398
Improved nice print to give literal values #10398
Conversation
Good timing, it has been fixed yesterday. 🙂 |
Yep, all good now! Thanks @auduchinok |
The bracket syntax is a bit strange IMO. Would it be better for the tooltip to be:
|
@auduchinok pointed out that val name could be reported as literal and highlighted accordingly. I can try address that in another PR. |
Already fixed :) |
Yeah, this is where things get weird. Is it more correct to show it as a normal |
We could probably classify it properly at the FCS level so it would be up to the tooling if the additional info should be used. VS integration could then ignore the additional colors and fallback to the current ones where needed. |
Oh, I would personally color it differently in VS. That was the crux of my argument in favor of differentiating more, that editors have more options available to them. |
Testing is definitely lacking on this front. I suppose we'd be happy to have the start of a test suite here, but I don't think that's a prerequisite to get this merged. |
@cartermp Hey Phillip! Can you merge this please or there are some more things I need to do before that? |
* Improved nice print to give literal values * Addressed CR
This change enables pretty printing Const values. Need some help with deciding printing manner (currently I'm using parentheses to show literal value). Also, I'm not sure I used WordL api right but I hope I did.
Screenshots are from JetBrains Rider.
Seems like mapping from NumbericLiteral could be fixed in Rider as it reports wrong color for mkNumericLiteral, but okay with mkStringLiteral: