Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field names to the ILExceptionClause.FilterCatch constructor. #10559

Merged
merged 2 commits into from
Nov 29, 2020
Merged

Add field names to the ILExceptionClause.FilterCatch constructor. #10559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
130b9d0
Added field names to the ILExceptionClause.FilterCatch constructor.
ScottHutchinson Nov 28, 2020
6a34bfb
Update expected output for unit tests
ScottHutchinson Nov 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/fsharp/absil/il.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1228,7 +1228,7 @@ type ILInstr =
type ILExceptionClause =
| Finally of (ILCodeLabel * ILCodeLabel)
| Fault of (ILCodeLabel * ILCodeLabel)
| FilterCatch of (ILCodeLabel * ILCodeLabel) * (ILCodeLabel * ILCodeLabel)
| FilterCatch of filterRange: (ILCodeLabel * ILCodeLabel) * handlerRange: (ILCodeLabel * ILCodeLabel)
| TypeCatch of ILType * (ILCodeLabel * ILCodeLabel)

[<RequireQualifiedAccess; NoEquality; NoComparison>]
Expand Down
2 changes: 1 addition & 1 deletion src/fsharp/absil/il.fsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,7 @@ type ILInstr =
type ILExceptionClause =
| Finally of (ILCodeLabel * ILCodeLabel)
| Fault of (ILCodeLabel * ILCodeLabel)
| FilterCatch of (ILCodeLabel * ILCodeLabel) * (ILCodeLabel * ILCodeLabel)
| FilterCatch of filterRange: (ILCodeLabel * ILCodeLabel) * handlerRange: (ILCodeLabel * ILCodeLabel)
| TypeCatch of ILType * (ILCodeLabel * ILCodeLabel)

[<RequireQualifiedAccess; NoEquality; NoComparison>]
Expand Down
8 changes: 4 additions & 4 deletions tests/FSharp.Compiler.Service.Tests/SurfaceArea.netstandard.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1600,10 +1600,10 @@ FSharp.Compiler.AbstractIL.IL+ILExceptionClause+FilterCatch: Int32 GetHashCode(S
FSharp.Compiler.AbstractIL.IL+ILExceptionClause+FilterCatch: Int32 Tag
FSharp.Compiler.AbstractIL.IL+ILExceptionClause+FilterCatch: Int32 get_Tag()
FSharp.Compiler.AbstractIL.IL+ILExceptionClause+FilterCatch: System.String ToString()
FSharp.Compiler.AbstractIL.IL+ILExceptionClause+FilterCatch: System.Tuple`2[System.Int32,System.Int32] Item1
FSharp.Compiler.AbstractIL.IL+ILExceptionClause+FilterCatch: System.Tuple`2[System.Int32,System.Int32] Item2
FSharp.Compiler.AbstractIL.IL+ILExceptionClause+FilterCatch: System.Tuple`2[System.Int32,System.Int32] get_Item1()
FSharp.Compiler.AbstractIL.IL+ILExceptionClause+FilterCatch: System.Tuple`2[System.Int32,System.Int32] get_Item2()
FSharp.Compiler.AbstractIL.IL+ILExceptionClause+FilterCatch: System.Tuple`2[System.Int32,System.Int32] filterRange
FSharp.Compiler.AbstractIL.IL+ILExceptionClause+FilterCatch: System.Tuple`2[System.Int32,System.Int32] handlerRange
FSharp.Compiler.AbstractIL.IL+ILExceptionClause+FilterCatch: System.Tuple`2[System.Int32,System.Int32] get_filterRange()
FSharp.Compiler.AbstractIL.IL+ILExceptionClause+FilterCatch: System.Tuple`2[System.Int32,System.Int32] get_handlerRange()
FSharp.Compiler.AbstractIL.IL+ILExceptionClause+Finally: Boolean Equals(ILExceptionClause)
FSharp.Compiler.AbstractIL.IL+ILExceptionClause+Finally: Boolean Equals(System.Object)
FSharp.Compiler.AbstractIL.IL+ILExceptionClause+Finally: Boolean Equals(System.Object, System.Collections.IEqualityComparer)
Expand Down