Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling] Prevent impl files with backing sig files from invalidating the build #10650

Merged
merged 2 commits into from
Dec 10, 2020

Conversation

TIHan
Copy link
Contributor

@TIHan TIHan commented Dec 9, 2020

Implements this: #10210

The refactor of incremental build has payed off. In the end, the solution to this required only a few changes.

The perf impact at the moment is completely night and day. Modifying then saving an impl file that has a backing sig file - is almost zero cost when VS/Roslyn tries to analyze other files that depend on it.

@TIHan TIHan changed the title Prevent impl files with backing sig files from invalidating the build [Tooling] Prevent impl files with backing sig files from invalidating the build Dec 9, 2020
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is excellent. Love how simply the change is too.

@TIHan TIHan merged commit a69ed90 into dotnet:main Dec 10, 2020
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
… the build (dotnet#10650)

* Prevent impl files with backing sig files from invalidating the build

* Check states on invalidate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip parse/type-check of other files when modifying implementation files with backing signature files
2 participants