Code

Set: comparer optimization#10861

Code

Closed

buybackoff wants to merge 15 commits intodotnet:maindotnet/fsharp:mainfrom buybackoff:set_step3buybackoff/fsharp:set_step3Copy head branch name to clipboard

+581-421

Commits

Commits on Jan 6, 2021

• Map: Optimize away ininst check

  Show description for 9f21d51
  buybackoff

  committed
  9f21d51

  Copy full SHA for 9f21d51

Commits on Jan 7, 2021

• Map: use if instead of match

  Show description for aa0572c
  buybackoff

  committed
  aa0572c

  Copy full SHA for aa0572c

Commits on Jan 10, 2021

• Map: Optimize away ininst check: fix trace

  buybackoff

  committed
  bc28258

  Copy full SHA for bc28258

• Set: Optimize away isinst check

  Show description for 2ccfed3
  buybackoff

  committed
  2ccfed3

  Copy full SHA for 2ccfed3

• Set: Optimize away isinst check: remove duplicate compare call in add

  buybackoff

  committed
  79a8e7f

  Copy full SHA for 79a8e7f

• Set: Optimize away isinst check: fix stack overflow

  buybackoff

  committed
  1475159

  Copy full SHA for 1475159

• Map: optimize comparer

  Show description for d6ffe5c
  buybackoff

  committed
  d6ffe5c

  Copy full SHA for d6ffe5c

• Map: optimize comparer: add floats & IComparable support

  buybackoff

  committed
  993ca9c

  Copy full SHA for 993ca9c

• Map: optimize comparer: replace embedded IL with verifiable operations

  buybackoff

  committed
  64dc698

  Copy full SHA for 64dc698

• Map: optimize comparer: CI was fine without IComparable

  buybackoff

  committed
  2a21940

  Copy full SHA for 2a21940

• Map: optimize comparer: limit types to optimize for IComparable

  Show description for e9e22b4
  buybackoff

  committed
  e9e22b4

  Copy full SHA for e9e22b4

• Map: optimize comparer: IComparable<T> should always be used when available

  Show description for 5885b54
  buybackoff

  committed
  5885b54

  Copy full SHA for 5885b54

• Map: optimize comparer: move default compare logic to a separate file to share later with Set

  buybackoff

  committed
  b09e5a2

  Copy full SHA for b09e5a2

• Set: optimize comparer

  Show description for 3386a33
  buybackoff

  committed
  3386a33

  Copy full SHA for 3386a33

• Set: optimize comparer: Set.Compare returns only [-1,0,1]

  buybackoff

  committed
  0900934

  Copy full SHA for 0900934