Stack-overflow fix #10868
Merged
Stack-overflow fix #10868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests that are failing are just the surface area. Will update those. |
|
Yes, Will update those indeed. Badum-tisshhh |
cartermp
pushed a commit
to cartermp/fsharp
that referenced
this pull request
Jan 21, 2021
* Backing out stackoverflow fix by delayed gen methods * Trying to lazily gen IL * Making ILMethodBody.IL be lazy * Consolidating lazy methodbodies by removing ILLazyMethodBody * Updating baseline and fixing build * Minor change
cartermp
added a commit
that referenced
this pull request
Jan 21, 2021
Cherry Pick into 16.9 - Stack-overflow fix (#10868)
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* Backing out stackoverflow fix by delayed gen methods * Trying to lazily gen IL * Making ILMethodBody.IL be lazy * Consolidating lazy methodbodies by removing ILLazyMethodBody * Updating baseline and fixing build * Minor change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10443
I'm not sure exactly why this is stack-overflowing, but it's related to a stack-overflow fix that I made about a year ago when delaying method gen in a queue.
The change basically delays the direct call of the code-gen for an expression on a method, instead of delaying the code-gen of the method itself. This is done by changing
MethodBody.ILto use aLazy<ILMethodBody>- this also allows the removal ofILLazyMethodBodyasMethodBody.ILwill always contain aLazy<ILMethodBody>.