Use collection functions from FSharp.Core when possible #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2028,7 +2028,7 @@ and ReportNoCandidatesError (csenv:ConstraintSolverEnv) (nUnnamedCallerArgs,nNam | |||
| let errid = | |||
| let suggestNamesForMissingArguments = | |||
| if nReqd > nActual then | |||
| let missingArgs = List.drop nReqd cmeth.AllUnnamedCalledArgs | |||
| let missingArgs = List.skip nReqd cmeth.AllUnnamedCalledArgs | |||
There was a problem hiding this comment.
List.drop is not an exact replacement for List.skip because it doesn't throw an exception when the list is too short. I think it's best to revert this to be on the safe side.
There was a problem hiding this comment.
Feel free to add an assert to List.drop that the list is long enough
|
@forki If you can backout the List.drop changes then I think this is ready to go in. |
|
removed that drop change |
forki
force-pushed
the
collections
branch
2 times, most recently
from
a030cdd to
3fa05c5
Compare
|
OK, this can go in, I'll merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.