Small cleanup in hot path of NameResolution #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| DepthCheck ndeep m ++ (fun () -> | ||
| match ty1 with | ||
| | TType_var r | TType_measure (MeasureVar r) -> | ||
| // The types may still be equivalent due to abbreviations, which we are trying not to eliminate | ||
| if typeEquiv csenv.g ty1 ty then CompleteD else | ||
|
|
||
| // The famous 'occursCheck' check to catch things like 'a = list<'a> | ||
| if occursCheck csenv.g r ty then ErrorD (ConstraintSolverInfiniteTypes(denv,ty1,ty,m,m2)) else | ||
| if occursCheck csenv.g r ty then ErrorD (ConstraintSolverInfiniteTypes(csenv.DisplayEnv,ty1,ty,m,m2)) else |
There was a problem hiding this comment.
We may reindent and space the tuple
if occursCheck csenv.g r ty then
ErrorD (ConstraintSolverInfiniteTypes(csenv.DisplayEnv, ty1, ty, m, m2))
else
// keep same indentation there, that fun () is hugeor at least keep the else on the next line
@dsyme what is up with style of spacing in tuples? I've seen some fortran codebase where those won't have any spaces between each argument in the list, I think it reads better with spacing but not sure what you prefer for the compiler codebase.
There was a problem hiding this comment.
Space-after-comma is preferred. But as per my comment on another thread, that would go in a separate cleanup PR.
|
This all looks good - added some comments above. |
|
@forki Kevin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.