Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code cleanup #12121

Merged
merged 10 commits into from
Sep 16, 2021
Merged

code cleanup #12121

merged 10 commits into from
Sep 16, 2021

Conversation

dsyme
Copy link
Contributor

@dsyme dsyme commented Sep 7, 2021

some non-urgent code cleanup, will do some more soon

Copy link
Member

@auduchinok auduchinok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions about a preferred code style.

src/fsharp/CheckComputationExpressions.fs Show resolved Hide resolved
src/fsharp/CheckComputationExpressions.fs Show resolved Hide resolved
src/fsharp/CheckComputationExpressions.fs Show resolved Hide resolved
src/fsharp/CheckComputationExpressions.fs Show resolved Hide resolved
@dsyme
Copy link
Contributor Author

dsyme commented Sep 7, 2021

Just a few questions about a preferred code style.

THis was just un-indenting stuff, I wasn't cleaning up the style :))

I think we'll adjust all of the code of the compiler to match https://docs.microsoft.com/en-us/dotnet/fsharp/style-guide/formatting

@auduchinok
Copy link
Member

THis was just un-indenting stuff, I wasn't cleaning up the style :))

Yeah, I hadn't realized it until wrote a bunch of comments. :)

@dsyme dsyme changed the title [WIP] code cleanup code cleanup Sep 16, 2021
@dsyme
Copy link
Contributor Author

dsyme commented Sep 16, 2021

@TIHan @vzarytovskii @KevinRansom This is ready

@TIHan TIHan merged commit 792a5d4 into dotnet:main Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants