Reduce memory allocations #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce allocations futher
Fix bug in error reporting
fix condition change fsc.exe GCLatencyMode to LowLatency as it showed better performance than Batch Revert "change fsc.exe GCLatencyMode to LowLatency as it showed better performance than Batch" This reverts commit 828dfab.
Closed
vasily-kirichenko
changed the title
|
@dotnet-bot test this please |
|
OK, I understand the changes in scanUntilSentinel now - I hadn't noticed the function was being passed around as a first class value. |
|
Looks good to me, |
|
Yes, this is good - I will merge it. |
|
@vasily-kirichenko Thanks for persevering with us on this, and resubmitting :) |
|
:) It's only sad that it's not speed the compiler up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(edited: KR): Previous PR thread: reduce allocations #1207