Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSharp.Core examples added to doc-comments #12211

Merged
merged 10 commits into from
Oct 11, 2021

Conversation

sgoguen
Copy link
Contributor

@sgoguen sgoguen commented Oct 5, 2021

No description provided.

* Arithmetic
* Bitwise Operators
* Comparison Operators
* Composition and Pipeline Operators
* defaultArgs
* raise, reraise, Failure
* Tuple fst, snd
@dnfadmin
Copy link

dnfadmin commented Oct 5, 2021

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@dsyme dsyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I've left some initial comments - I'll review again when you're ready

src/fsharp/FSharp.Core/prim-types.fsi Outdated Show resolved Hide resolved
src/fsharp/FSharp.Core/prim-types.fsi Outdated Show resolved Hide resolved
src/fsharp/FSharp.Core/prim-types.fsi Outdated Show resolved Hide resolved
src/fsharp/FSharp.Core/prim-types.fsi Outdated Show resolved Hide resolved
src/fsharp/FSharp.Core/prim-types.fsi Outdated Show resolved Hide resolved
src/fsharp/FSharp.Core/prim-types.fsi Outdated Show resolved Hide resolved
src/fsharp/FSharp.Core/prim-types.fsi Outdated Show resolved Hide resolved
src/fsharp/FSharp.Core/prim-types.fsi Outdated Show resolved Hide resolved
src/fsharp/FSharp.Core/prim-types.fsi Outdated Show resolved Hide resolved
src/fsharp/FSharp.Core/prim-types.fsi Outdated Show resolved Hide resolved
@dsyme
Copy link
Contributor

dsyme commented Oct 11, 2021

@sgoguen I've updated your branch with a few fixes

@dsyme dsyme enabled auto-merge (squash) October 11, 2021 13:09
@dsyme dsyme disabled auto-merge October 11, 2021 13:18
@dsyme
Copy link
Contributor

dsyme commented Oct 11, 2021

@sgougen I will merge this - some examples remain to be filled in but it is still in decent shape. We can fill those in next

@dsyme
Copy link
Contributor

dsyme commented Oct 11, 2021

@sgoguen Thank you so much for this contribution, and let's continue #12124 to the finishing line!

@dsyme dsyme merged commit 77ef177 into dotnet:main Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants