Fix for loaded script files ignoring #nowarn #1239
Merged
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1072,6 +1072,8 @@ type internal FsiDynamicCompiler | |||
| else fsiConsoleOutput.uprintnf " %s %s" (FSIstrings.SR.fsiLoadingFilesPrefixText()) sourceFile) | |||
| fsiConsoleOutput.uprintfn "]" | |||
|
|
|||
| closure.NoWarns |> Seq.map (fun (n,ms) -> ms |> Seq.map (fun m -> m,n)) |> Seq.concat |> Seq.iter tcConfigB.TurnWarningOff | |||
There was a problem hiding this comment.
This looks like good. Had to go look up a few things to check, but it looks right.
|
The fix is good and the test appropriate. |
| @@ -44,4 +44,6 @@ echo Test 16================================================= | |||
| "%FSC%" ProjectDriver.fsx --nologo | |||
| ProjectDriver.exe | |||
| del ProjectDriver.exe | |||
| echo Test 17================================================= | |||
There was a problem hiding this comment.
@enricosada has a pending PR that deletes these old test .bat files, but I didn't know about it until after I submitted this and I suppose this might cause a little merge conflict
There was a problem hiding this comment.
np @taylorwood , i'll rebase, dont care about my pr, you already update the tests/fsharp/core/tests_core.fs so it's ok
|
@taylorwood Kevin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a stab at fixing issue #1126. It didn't seem that the loaded script closure's
#nowarndirectives were being applied infsi, like they are infschere: https://github.com/Microsoft/visualfsharp/blob/master/src/fsharp/fsc.fs#L241I wasn't sure where a test might belong so I stuck one in a convenient place. Here's what it looks like w/o the fix in place:
