Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put union erasure in IlxGen phase #1250

Merged
merged 4 commits into from
Jun 8, 2016
Merged

Put union erasure in IlxGen phase #1250

merged 4 commits into from
Jun 8, 2016

Conversation

dsyme
Copy link
Contributor

@dsyme dsyme commented Jun 7, 2016

This eliminates the "Union" rewrite phase and means IlxGen now directly generates IL.

This PR changes IL code generation and a bunch of baselines will need to be updated because the order in which locals are generated changes.

Next? There is still a very awkward, expensive and complexifying code transformation done as part of IlxGen from

"list of instructions" --> "structured code" --> "list of instructions" 

which I believe can be eliminated next.

@dsyme
Copy link
Contributor Author

dsyme commented Jun 7, 2016

Note, 300 LOC disappear with this phase removal. There may also be a marginal performance improvement but I need to double check

@brodyberg
Copy link

I love it

On Tuesday, June 7, 2016, Don Syme notifications@github.com wrote:

Note, 300 LOC disappear with this phase removal


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1250 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAJRk652P6Gv0imW5OpdPLKktg6-lx37ks5qJeCogaJpZM4IwElP
.

@dsyme
Copy link
Contributor Author

dsyme commented Jun 8, 2016

I am merging this since it is cleanup and all green

@dsyme dsyme merged commit a58efbf into dotnet:master Jun 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants