Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Underscore literals - fix float parsing and add negative tests #1256

Merged
merged 3 commits into from
Jun 20, 2016
Merged

Underscore literals - fix float parsing and add negative tests #1256

merged 3 commits into from
Jun 20, 2016

Conversation

AviAvni
Copy link
Contributor

@AviAvni AviAvni commented Jun 10, 2016

No description provided.

@AviAvni AviAvni mentioned this pull request Jun 10, 2016
Merged
@khyperia
Copy link

Awesome! (Just as FYI to reviewers, this addresses all of my specific concerns in the original PR)

@AviAvni
Copy link
Contributor Author

AviAvni commented Jun 16, 2016

@dsyme please review

@dsyme
Copy link
Contributor

dsyme commented Jun 16, 2016

LGTM @KevinRansom THis is ready to merge

@dsyme
Copy link
Contributor

dsyme commented Jun 17, 2016

@khyperia Thank you so much for your diligence

@KevinRansom KevinRansom merged commit 94e125a into dotnet:master Jun 20, 2016
@KevinRansom
Copy link
Member

@AviAvni Thank you for taking care of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AviAvni @khyperia @dsyme @KevinRansom @msftclas