Added examples for Async.WebExtensions #12644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
30 tasks
dsyme
reviewed
Jan 26, 2022
src/fsharp/FSharp.Core/async.fsi
Outdated
| /// <example-tbd></example-tbd> | ||
| /// <example id="get-response"> | ||
| /// <code lang="fsharp"> | ||
| /// let responseStreamToString = fun (responseStream : System.Net.WebResponse) -> |
There was a problem hiding this comment.
You can add open System and open System.IO and open System.Net at the top of the sample I think. Best to keep the code crisp.
dsyme
reviewed
Jan 26, 2022
src/fsharp/FSharp.Core/async.fsi
Outdated
| /// <example id="async-download-string"> | ||
| /// <code lang="fsharp"> | ||
| /// let client = new WebClient() | ||
| /// System.Uri("https://www.microsoft.com") |> client.AsyncDownloadString |> Async.RunSynchronously |
There was a problem hiding this comment.
Change to a more neutral URL like https://www.w3.org/
dsyme
reviewed
Jan 26, 2022
src/fsharp/FSharp.Core/async.fsi
Outdated
| /// <example id="async-download-data"> | ||
| /// <code lang="fsharp"> | ||
| /// let client = new WebClient() | ||
| /// client.AsyncDownloadData(Uri("https://www.microsoft.com")) |> Async.RunSynchronously |> System.Text.Encoding.ASCII.GetString |
There was a problem hiding this comment.
Likewise here, use https://www.w3.org/
dsyme
reviewed
Jan 26, 2022
src/fsharp/FSharp.Core/async.fsi
Outdated
| /// <example id="async-download-file"> | ||
| /// <code lang="fsharp"> | ||
| /// let client = new System.Net.WebClient() | ||
| /// System.Uri("https://www.microsoft.com") |> fun x -> client.AsyncDownloadFile(x, "output.html") |> Async.RunSynchronouslyl |
There was a problem hiding this comment.
Likewise here, use https://www.w3.org/
dsyme
requested changes
Jan 26, 2022
|
@dsyme - Thank you for reviewing. I've updated the files. |
dsyme
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dsyme --
Not sure if it's worth adding examples here because
WebClientis deprecated in favor ofHttpClientbut I did it anyway.Please see FSharp.Control.Async.WebExtensions #12124