Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes typo in #1129 #1305

Merged
merged 1 commit into from
Jul 1, 2016
Merged

Fixes typo in #1129 #1305

merged 1 commit into from
Jul 1, 2016

Conversation

toburger
Copy link

@toburger toburger commented Jul 1, 2016

Title:

Fixes typo in #1129

Description:

The correct byte literal is 1uy

Repro Steps:

Start fsi, type a number with an invalid byte literal like e.g. 1A

Expected:

This is not a valid numeric literal. Valid numeric literals include 1, 0x1, 0b0001 (int), 1u (uint32), 1L (int64), 1UL (uint64), 1s (int16), 1y (sbyte), 1uy (byte), 1.0 (float), 1.0f (float32), 1.0m (decimal), 1I (BigInteger).

Actual:

This is not a valid numeric literal. Valid numeric literals include 1, 0x1, 0b0001 (int), 1u (uint32), 1L (int64), 1UL (uint64), 1s (int16), 1y (sbyte), 1ui (byte), 1.0 (float), 1.0f (float32), 1.0m (decimal), 1I (BigInteger).

Severity:

Low

Version:

F# vNext

@msftclas
Copy link

msftclas commented Jul 1, 2016

Hi @toburger, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

@dsyme dsyme merged commit 0247247 into dotnet:master Jul 1, 2016
@dsyme
Copy link
Contributor

dsyme commented Jul 1, 2016

Thanks!

@toburger toburger deleted the fix-byte-literal branch July 1, 2016 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants