-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC FS-1124 - Interfaces with static abstract methods #13119
Merged
vzarytovskii
merged 126 commits into
dotnet:main
from
vzarytovskii:statics-in-interfaces-2
Aug 9, 2022
Merged
Changes from 1 commit
Commits
Show all changes
126 commits
Select commit
Hold shift + click to select a range
3814613
WIP: Support implementing statics in interfaces
vzarytovskii ff0deda
Cleanup (#13113)
dsyme 7ce8b63
Revert "Cleanup (#13113)"
vzarytovskii adade8a
Merge remote-tracking branch 'upstream/main' into statics-in-interfac…
vzarytovskii baef7c4
WIP
vzarytovskii a84bd24
Merge 'main'
vzarytovskii 44ae728
Removed double check for non-abstract interface
vzarytovskii f2c2e48
Merge remote-tracking branch 'upstream/main' into statics-in-interfac…
vzarytovskii 1d9c753
Merge remote-tracking branch 'upstream/main' into statics-in-interfac…
vzarytovskii f2d160a
Merge remote-tracking branch 'upstream/main' into statics-in-interfac…
vzarytovskii e91659d
Merge remote-tracking branch 'upstream/main' into statics-in-interfac…
vzarytovskii b36215a
Merge remote-tracking branch 'upstream/main' into statics-in-interfac…
vzarytovskii ebe1050
WIP
vzarytovskii 5cf713c
Merge remote-tracking branch 'upstream/main' into statics-in-interfac…
vzarytovskii c200abd
WIP
vzarytovskii 6762674
Merge remote-tracking branch 'upstream/main' into statics-in-interfac…
vzarytovskii 2168e1e
WIP
vzarytovskii c91c73f
WIP
vzarytovskii 747e8f1
Merge remote-tracking branch 'origin/main' into statics-in-interfaces-2
vzarytovskii 8b31c82
WIP: Fixed method codegen
vzarytovskii 470952e
Merge branch 'main' into statics-in-interfaces-2
vzarytovskii 40916ee
Fixes to style + indent
vzarytovskii 92fdf2a
After merge fixes
vzarytovskii f74ecf2
WIP: add language and runtime feature
vzarytovskii 018bfd0
Fixed feature guard
vzarytovskii 810a51f
Fixed the immediate members filter
vzarytovskii 15178c8
Merge branch 'main' into statics-in-interfaces-2
vzarytovskii 9e86055
Fix tests baselines
vzarytovskii d2e96c7
Fix tests baselines
vzarytovskii c0aac06
fix for list pattern syntax
vzarytovskii 82a079e
Added operators tests
vzarytovskii e6ad912
allow authoring and fix abstract slot inference
dsyme be1909c
add tests
dsyme 7546888
Merge pull request #2 from dsyme/statics-in-interfaces-2
vzarytovskii 7262f1f
fix build
dsyme 9b00827
Merge branch 'statics-in-interfaces-2' of https://github.com/vzarytov…
dsyme aa03f82
Update surface area tests
vzarytovskii a6b7118
Merge branch 'main' of https://github.com/dotnet/fsharp into statics-…
dsyme 6122923
Apply fantomas
vzarytovskii b512c93
add call syntax and emit constrained prefix
dsyme d4504db
Merge pull request #3 from dsyme/statics-in-interfaces-2
vzarytovskii 3355110
fix parsing problems, allow invocation and support name resolution of…
dsyme 8520647
merge main
dsyme cc574a8
merge main
dsyme aeade7a
fix from-end-slicing
dsyme 85e3997
Self constraints; Disallow ^T; Full test matrix for propery SRTP cons…
dsyme c038f9c
update samples
dsyme 74a996d
Merge branch 'main' of https://github.com/dotnet/fsharp into statics-…
dsyme 7dcd465
fix tests
dsyme 273e206
git first execution test working
dsyme b2f8c28
Merge branch 'main' of https://github.com/dotnet/fsharp into statics-…
dsyme 13fa09b
Merge branch 'main' of https://github.com/dotnet/fsharp into statics-…
dsyme 555fbbe
update formating
dsyme 1fe8d22
merge and fix test
dsyme 4b983f0
merge main
dsyme 3874fa5
fix tests
dsyme 28bea4a
fix tests
dsyme 3432f30
allow IWSAM constraints to solve SRTP traits
dsyme ce57d10
fix to signature compat
dsyme a864274
Merge branch 'main' of https://github.com/dotnet/fsharp into statics-…
dsyme fb8b75c
format code
dsyme b33b80b
fix task tests
dsyme de6ec1a
Merge branch 'main' of https://github.com/dotnet/fsharp into statics-…
dsyme 243c207
fix test
dsyme 09f7f17
fix up tests
dsyme 4200b5e
fix test
dsyme 13b97fc
add warnings to match RFC
dsyme 7eeae6d
update messages and protect changes
dsyme 7f6a46d
clear static req for inference variables
dsyme 01f6ec4
clear static req for inference variables
dsyme 9f9c49a
fix another case of generalization
dsyme d0544e4
fix build
dsyme 8438abd
fix formatting
dsyme 1b71be2
Merge branch 'main' of https://github.com/dotnet/fsharp into statics-…
dsyme aa5820a
fix tests
dsyme 87e1304
fix tests
dsyme 03f7bef
add tests and improve diagnostics
dsyme 7ee7e07
format code
dsyme ab95b72
fix tests
dsyme a254a88
add more quickinfo etc tests
dsyme 19a4934
clean up tests
dsyme d6da718
Merge branch 'main' into statics-in-interfaces-2
dsyme 79ae597
merge main
dsyme c9e6284
format code
dsyme 6df8a34
fix build
dsyme a5d56a3
merge main
dsyme 9d33a53
Update LanguageFeatures.fs
dsyme e36b205
merge main
dsyme fb50126
merge main
dsyme 5aaa9a1
fix build
dsyme 6c783a7
Moved tests/adhoc to ComponentTests
0101 cb21cef
Updated new syntax test
0101 aaf86b7
Updated new syntax test
0101 ef8fecf
Disabling failing tests for now
0101 218f9ee
Fix new SRTP instance method invocation
0101 1ac2e27
Func conversion tests, renaming
0101 22aa7d5
Verify IL for IWSAM test
0101 c464aef
Byref tests
0101 aa8b80a
Test creating delegates to IWSAM-constrained target methods
0101 6145058
Tests for implicit conversion and nominal type in constraint selector
0101 1a3bb71
IWSAM active patterns tests
0101 9e760a6
Test for C# using IWSAM defined in F#
0101 ce3aa0d
Release IL in test
0101 6681e16
Merge branch 'main' into statics-in-interfaces-2
0101 8b8427a
Fix test
0101 bc8d9b8
Skip IWSAM tests on NET FW
0101 86d3552
merge main
dsyme ed56f7e
fix build
dsyme 143045d
fix build
dsyme 881d431
fix test
dsyme 2ae12a5
fix inference tests
dsyme 4605e77
Updated type inference tests
0101 5b2c6e2
Merge branch 'statics-in-interfaces-2' of github.com:vzarytovskii/fsh…
0101 7b96494
Fix compiler generated attribute for setters
0101 23f0c61
Prepared System.Numerics suppression test
0101 5c404c0
Sample project for .NET 7
0101 ef3ae6c
fix byref arguments to trait calls
dsyme c700443
fix byref arguments to trait calls
dsyme 80f1833
Added more samples, fixed compiler paths for VS
vzarytovskii c59553a
DirectoryAttribute puts each test into its own directory
0101 713416a
Merge branch 'statics-in-interfaces-2' of github.com:vzarytovskii/fsh…
0101 540ba37
Only add extra dir for test if there multiple tests processed by Dire…
0101 3fbcb5d
Moved adhoc byref tests to actual tests
0101 a76d013
Tests update
0101 3a847d8
Merge branch 'main' into statics-in-interfaces-2
0101 5629ef4
Merge branch 'main' into statics-in-interfaces-2
vzarytovskii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests look good!
Probably add a test when the user defines an interface in System.Numerics too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also one where the user defines a new interface NOT in System.Numerics but derives from an interface in System.Numerics