Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format src/Compiler/Service #13238

Merged
merged 24 commits into from
Jun 8, 2022
Merged

Format src/Compiler/Service #13238

merged 24 commits into from
Jun 8, 2022

Conversation

dsyme
Copy link
Contributor

@dsyme dsyme commented Jun 2, 2022 •
edited
Loading

Has some preformatting adjustment of code, including cleanup in ServiceNavigation.fs

It is a big set of changes

  • I've been through the code carefully
  • Applied a considerable amount of pre-formatting adjustments
  • Used some bespoke settings in .editorconfig for some files that were particularly affected.

Several files fail formatting, they will be investigated separately:

src/Compiler/Service/IncrementalBuild.fs
src/Compiler/Service/ServiceAssemblyContent.fs
src/Compiler/Service/ServiceDeclarationLists.fs
src/Compiler/Service/ServiceErrorResolutionHints.fs

@dsyme
Copy link
Contributor Author

dsyme commented Jun 3, 2022 •
edited
Loading

This is ready for review.

@dsyme dsyme changed the title Format most of src\Compiler\Service Format src/Compiler/Service Jun 3, 2022
@vzarytovskii
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@KevinRansom KevinRansom merged commit 0155fd5 into dotnet:main Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinRansom KevinRansom KevinRansom approved these changes

@vzarytovskii vzarytovskii vzarytovskii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsyme @vzarytovskii @KevinRansom