Implement Ctrl+C on coreclr #13428
Merged
Implement Ctrl+C on coreclr #13428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
reviewed
Jul 1, 2022
|
|
||
| open Internal.Utilities.FSharpEnvironment | ||
|
|
||
| type ControlledExecution (thread:Thread) = |
dsyme
approved these changes
Jul 1, 2022
vzarytovskii
approved these changes
Jul 1, 2022
|
@KevinRansom Can you manually test behaviour when cancelling using the Visual Studio IDE please? thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ctrl+c handling on dotnet 6.0 is broken:
With this change it will still not work correctly on dotnet 6.0, but at least it won't crash.
On dotnet 7.0, after the feature is committed it will light up and work correctly:
Desktop fsi will continue to work as it does today.