Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable f sharp70 #13688

Merged
merged 13 commits into from
Aug 23, 2022
Merged

Enable f sharp70 #13688

merged 13 commits into from
Aug 23, 2022

Conversation

KevinRansom
Copy link
Member

  • Update F# Language version to 7.0
  • Update FSharp.Core to 7.0.0.0
  • Update FSharp.Core.nuget to 7.0.0
  • Update FCS Compiler Package to 42.7.100.0 - aligned with dotnet 7.0.100 sdk
  • Fix fsharp.core assembly version on proto build to match version shipped with vs, remove nuget package hack
  • Fix tests that use preview to use LangVersion70.

@abelbraaksma
Copy link
Contributor

Is this per chance the reason why local build.cmd is currently failing on constructs with no space between the < and ^t? I know that was part of #13119, but after I updated my fork I got a couple dozen errors, even after cleaning and running build.cmd again.

If not, I’ll continue research why this happens, or report separately.

@vzarytovskii
Copy link
Member

Is this per chance the reason why local build.cmd is currently failing on constructs with no space between the < and ^t? I know that was part of #13119, but after I updated my fork I got a couple dozen errors, even after cleaning and running build.cmd again.

If not, I’ll continue research why this happens, or report separately.

It sounds like proto compiler not being rebuild, and older one is used.

@abelbraaksma
Copy link
Contributor

It sounds like proto compiler not being rebuild, and older one is used.

@vzarytovskii, that was my initial thought. I’ll doublecheck if all artefacts get properly removed with git clean -xdf and try again. But from the log, I did see it rebuild. Perhaps the file was in use and I missed that. 🤔

@abelbraaksma
Copy link
Contributor

@vzarytovskii: sorry for the noise. Somehow I had more recent Fharp.Core.Test files, including the <^t> syntax,, but the older compiler. A proper git fetch upstream etc solved it.

vzarytovskii
vzarytovskii reviewed Aug 16, 2022
View reviewed changes
src/Compiler/Facilities/LanguageFeatures.fs
// F# preview
LanguageFeature.FromEndSlicing, previewVersion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move the from end slicing too? I thought it needs some work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

vzarytovskii
vzarytovskii reviewed Aug 16, 2022
View reviewed changes
tests/fsharp/typecheck/sigs/temp Outdated
@@ -0,0 +1,116 @@

Copy link
Member

@vzarytovskii vzarytovskii Aug 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are temp and temp2 sigs here on purpose?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

vzarytovskii
vzarytovskii reviewed Aug 22, 2022
View reviewed changes
src/FSharp.Core/prim-types.fsi
@@ -2555,7 +2555,6 @@ namespace Microsoft.FSharp.Collections
/// <param name="offset">The offset from the end.</param>
///
/// <returns>The corresponding index from the start.</returns>
[<Experimental("Experimental library feature, requires '--langversion:preview'")>]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the from end slicing remains in preview, shall those methods too?

@KevinRansom KevinRansom merged commit 9978a14 into dotnet:main Aug 23, 2022
@allisonchou allisonchou mentioned this pull request Aug 24, 2022
Closed
@KevinRansom KevinRansom deleted the enableFSharp70 branch October 12, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinRansom @abelbraaksma @vzarytovskii