Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra space when first type argument is a statically resolved type parameter #13825

Closed
wants to merge 1 commit into from

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Sep 1, 2022

Fixes #13760.

@abelbraaksma
Copy link
Contributor

It should be noted that with the PR for static interfaces, the space is no longer required. If this could be merged in a point release it’s still beneficial. But if the next release is going to include that PR (by @vzarytovskii, iirc, but I forgot the link), this one would become moot.

Alternatively, we could cherry pick the parts of that PR that fixes the parsing of static generic types.

@vzarytovskii
Copy link
Member

The PR should be in main already. Also, ' can now be used instead of ^.

@nojaf
Copy link
Contributor Author

nojaf commented Sep 1, 2022

Hmm, if there are still dotnet 6.0.x releases coming, I'd still like to have this fix in.
The whole static interfaces thing is dotnet 7 right?

@vzarytovskii
Copy link
Member

vzarytovskii commented Sep 1, 2022

Hmm, if there are still dotnet 6.0.x releases coming, I'd still like to have this fix in.

Only servicing, which means high bar, pretty much only bugfixes. Probably the only thing we will be able to get in there is the fix for attribute checking compiler error.
Update Btw, we stopped auto-merging to .NET6 some time ago already.

The whole static interfaces thing is dotnet 7 right?

Yep, it is tied to runtime feature.

@nojaf
Copy link
Contributor Author

nojaf commented Sep 1, 2022

Ok, sounds reasonable not to have this PR then.

@nojaf nojaf closed this Sep 1, 2022
@abelbraaksma
Copy link
Contributor

For reference, this was fixed in this PR: #13119.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signature file generation does not handle statically resolved type parameter
3 participants