Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FSharp.Core references in FCS solution #13827

Merged
merged 8 commits into from
Sep 21, 2022
Merged

Fix FSharp.Core references in FCS solution #13827

merged 8 commits into from
Sep 21, 2022

Conversation

auduchinok
Copy link
Member

  • Adds missing 'project vs package' FSharp.Core reference checks to projects that were recently added to the service solution
  • Moves FSHARPCORE_USE_PACKAGE property initialization up to repo root

@auduchinok auduchinok changed the title Fs core refs Fix FSharp.Core references in FCS solution Sep 1, 2022
KevinRansom
KevinRansom previously approved these changes Sep 2, 2022
View reviewed changes
@KevinRansom KevinRansom dismissed their stale review September 2, 2022 21:00

Perhaps not yet ready.

@auduchinok
Copy link
Member Author

This is ready.

KevinRansom
KevinRansom approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@vzarytovskii vzarytovskii merged commit 342a6d2 into dotnet:main Sep 21, 2022
@allisonchou allisonchou mentioned this pull request Oct 12, 2022
Closed
auduchinok added a commit to JetBrains/fsharp that referenced this pull request Dec 7, 2022
@auduchinok @vzarytovskii @KevinRansom
Fix FSharp.Core references in FCS solution (dotnet#13827)
b493611 
* Allow using FSharp.Core package in new service solution projects

* Remove inner rules

* Another FSharp.Core reference

* Fix relative path

Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com>
Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinRansom KevinRansom KevinRansom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@auduchinok @KevinRansom @vzarytovskii