Use MSBuild's logging facilities instead of writing to console. #13896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, this is good staff. |
|
Oh, didn't see the CI failures. Sure, go ahead, thanks. |
T-Gro
previously approved these changes
Oct 12, 2022
T-Gro
approved these changes
Oct 12, 2022
|
@KevinRansom : |
psfinaki
reviewed
Oct 12, 2022
There was a problem hiding this comment.
It's a bit of unknown territory for me yet so my comments might be irrelevant a bit :)
Generally using the built-in logging mechanism instead of printfs everywhere is a right thing to do so I think this should get in - my comments are mostly about other changes here.
T-Gro
approved these changes
Oct 12, 2022
vzarytovskii
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repository's MSBuild tasks log messages directly to the console, which is more verbose than needed, cannot be made less verbose, and does not play well with MSBuild's logging facilities.
This PR changes the tasks to use the Lawful Good™ way of logging events. Also instead of implementing the
Microsoft.Build.Framework.ITaskinterface, they now inherit theMicrosoft.Build.Utilities.Taskclass, which is easier to use.