Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arcade update + changes that should allow the "release/devXY.Z" branches #14168

Merged
merged 2 commits into from
Oct 27, 2022

Conversation

MattGal
Copy link
Member

@MattGal MattGal commented Oct 24, 2022

Part of dotnet/arcade#10578. This should be integrate-able to branches like release/dev17**.x** and cause it to pick the correct pool provider automatically.

…hes to use the "correct" pool providers when building
@vzarytovskii
Copy link
Member

/backport to release/dev17.4

@vzarytovskii
Copy link
Member

/backport to release/dev17.3

@github-actions
Copy link
Contributor

Started backporting to release/dev17.4: https://github.com/dotnet/fsharp/actions/runs/3320020354

@github-actions
Copy link
Contributor

Started backporting to release/dev17.3: https://github.com/dotnet/fsharp/actions/runs/3320021195

@vzarytovskii
Copy link
Member

@MattGal do we need to backport it further to 17.2 and lower?

@github-actions
Copy link
Contributor

@vzarytovskii backporting to release/dev17.4 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Arcade update + changes that should allow the "release/devXY.Z" branches to use the "correct" pool providers when building
Using index info to reconstruct a base tree...
M	azure-pipelines.yml
M	eng/Version.Details.xml
M	eng/common/templates/job/source-build.yml
M	eng/common/tools.sh
M	global.json
Falling back to patching base and 3-way merge...
Auto-merging global.json
CONFLICT (content): Merge conflict in global.json
Auto-merging eng/common/tools.sh
Auto-merging eng/common/templates/job/source-build.yml
CONFLICT (content): Merge conflict in eng/common/templates/job/source-build.yml
Auto-merging eng/Version.Details.xml
CONFLICT (content): Merge conflict in eng/Version.Details.xml
Auto-merging azure-pipelines.yml
CONFLICT (content): Merge conflict in azure-pipelines.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Arcade update + changes that should allow the "release/devXY.Z" branches to use the "correct" pool providers when building
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@github-actions
Copy link
Contributor

@vzarytovskii backporting to release/dev17.3 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Arcade update + changes that should allow the "release/devXY.Z" branches to use the "correct" pool providers when building
Using index info to reconstruct a base tree...
M	azure-pipelines.yml
M	eng/Version.Details.xml
M	eng/common/templates/job/source-build.yml
M	eng/common/tools.sh
M	global.json
Falling back to patching base and 3-way merge...
Auto-merging global.json
CONFLICT (content): Merge conflict in global.json
Auto-merging eng/common/tools.sh
Auto-merging eng/common/templates/job/source-build.yml
CONFLICT (content): Merge conflict in eng/common/templates/job/source-build.yml
Auto-merging eng/Version.Details.xml
CONFLICT (content): Merge conflict in eng/Version.Details.xml
Auto-merging azure-pipelines.yml
CONFLICT (content): Merge conflict in azure-pipelines.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Arcade update + changes that should allow the "release/devXY.Z" branches to use the "correct" pool providers when building
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@vzarytovskii
Copy link
Member

Ok, it seems it's not as easy.

@vzarytovskii vzarytovskii enabled auto-merge (squash) October 27, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants