-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aligning constructor and type for Rename + FindAllReferences #14350
Merged
psfinaki
merged 13 commits into
dotnet:main
from
T-Gro:refactor-rename-doesnt-work-for-constructors
Nov 21, 2022
Merged
Aligning constructor and type for Rename + FindAllReferences #14350
psfinaki
merged 13 commits into
dotnet:main
from
T-Gro:refactor-rename-doesnt-work-for-constructors
Nov 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original issue : #13199 |
…//github.com/T-Gro/fsharp into refactor-rename-doesnt-work-for-constructors
psfinaki
previously approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Useful stuff, thanks!
abonie
previously approved these changes
Nov 18, 2022
0101
previously approved these changes
Nov 21, 2022
abonie
approved these changes
Nov 21, 2022
0101
approved these changes
Nov 21, 2022
psfinaki
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following code did not rename the constructor in " let a = ..." line, because the type and the constructor where considered to be different things in the binary store used for searching (which is consecutively used for renaming).
After the change, renaming gets applied correctly across all usages:
At the same time, the workflow DSL has been expanded to support:
And the search scenarios within file and across file covered by tests.