Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try-with inside seq{} expressions #14540

Merged
merged 22 commits into from
Feb 2, 2023
Merged

Try-with inside seq{} expressions #14540

merged 22 commits into from
Feb 2, 2023

Conversation

T-Gro
Copy link
Member

@T-Gro T-Gro commented Jan 4, 2023 •
edited
Loading

Implements RFC fsharp/fslang-design#726 .
Go there to find more details.

T-Gro added 15 commits December 27, 2022 12:18
@T-Gro
Broken code for trywith in seq
b40740a
@T-Gro
Merge branch 'main' into try-with-in-seq
25173a2
@T-Gro
try/with for sequence expressions - failing, but building
3fd3ccb
@T-Gro
Adding more tests
8f45864
@T-Gro
Failing test added - error at enumeration time not being caught!
2cff81f
@T-Gro
More tailored failing tests added
e3dc32d
@T-Gro
pushing 'with' clause into the generated state machine for chained ex…
8169555 
…pressions
@T-Gro
More test cases - recursion from with, inner try-finally inside of with
e132656
@T-Gro
combinator for trywith added, not yet hooked up
0b1a854
@T-Gro
Calling combinator from seqexpression translation (failing now, incor…
e40e6f8 
…rect CLR program)
@T-Gro
Fixing expressions to become lambdas
db5ada6
@T-Gro
Demonstrate slow recursion case
1f493f5
@T-Gro
Removing old version of the code
ee7e593
@T-Gro
Merge branch 'main' into try-with-in-seq
a44cfbe
@T-Gro
fantomas
3dfbb1a
@T-Gro T-Gro linked an issue Jan 9, 2023 that may be closed by this pull request
Support try-with in seq{} expressions #14569
Closed
@T-Gro T-Gro changed the title WIP: Try-with inside seq{} expressions. Prototype, not polished. Try-with inside seq{} expressions Jan 30, 2023
@T-Gro T-Gro marked this pull request as ready for review January 31, 2023 13:00
@T-Gro T-Gro requested a review from a team as a code owner January 31, 2023 13:00
T-Gro
T-Gro commented Feb 1, 2023
View reviewed changes
src/FSharp.Core/seqcore.fs Outdated Show resolved Hide resolved
src/FSharp.Core/seqcore.fs Outdated Show resolved Hide resolved
@vzarytovskii vzarytovskii merged commit c5096a2 into main Feb 2, 2023
@T-Gro T-Gro deleted the try-with-in-seq branch February 2, 2023 13:00
@allisonchou allisonchou mentioned this pull request Feb 17, 2023
Closed
@vzarytovskii vzarytovskii mentioned this pull request Oct 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@0101 0101 0101 approved these changes

Assignees
No one assigned
Labels
release/17.6
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support try-with in seq{} expressions
3 participants
@T-Gro @0101 @vzarytovskii