Fix parsing format specifiers and refactor #14685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonie
force-pushed
the
refactor-format-parsing-fix-14681
branch
3 times, most recently
from
c86ab7d to
06e4d56
Compare
abonie
force-pushed
the
refactor-format-parsing-fix-14681
branch
3 times, most recently
from
e2fdfad to
36ff149
Compare
abonie
force-pushed
the
refactor-format-parsing-fix-14681
branch
6 times, most recently
from
f8e751a to
6cbff6b
Compare
psfinaki
approved these changes
Feb 13, 2023
abonie
force-pushed
the
refactor-format-parsing-fix-14681
branch
3 times, most recently
from
9944446 to
b623ab3
Compare
abonie
force-pushed
the
refactor-format-parsing-fix-14681
branch
2 times, most recently
from
5cf1d4b to
ee7ea55
Compare
abonie
force-pushed
the
refactor-format-parsing-fix-14681
branch
from
ee7ea55 to
d9c692b
Compare
Change parsing format specifiers so that it first checks whether it sees escaped `%` before it starts parsing flags/width/precision.
abonie
force-pushed
the
refactor-format-parsing-fix-14681
branch
from
d9c692b to
c330a21
Compare
0101
approved these changes
Feb 16, 2023
KevinRansom
added a commit
to KevinRansom/fsharp
that referenced
this pull request
Feb 20, 2023
This reverts commit fac388c.
KevinRansom
added a commit
to KevinRansom/fsharp
that referenced
this pull request
Feb 20, 2023
This reverts commit fac388c.
kant2002
pushed a commit
to kant2002/fsharp
that referenced
this pull request
Apr 1, 2023
* Refactor, extract closures as separate functions * Add unit test * Fix the issue with format specifiers Change parsing format specifiers so that it first checks whether it sees escaped `%` before it starts parsing flags/width/precision. * Restore previous behavior but add a warning * Fix editor test * Fix hardcoded path in unit test --------- Co-authored-by: Adam Boniecki
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit is just some refactoring of CheckFormatStrings.fs, since it was pretty hard to read. I recommend reviewing it separately :)
The rest fixes: #14681