Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily skip 4 failing IL baseline tests - ReadOnlyAttribute behaviour changed #14744

Merged
merged 3 commits into from
Feb 13, 2023
Merged

Temporarily skip 4 failing IL baseline tests - ReadOnlyAttribute behaviour changed #14744

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2ebfc1
If background testsjob does not succeed, stop entire execution
T-Gro Feb 13, 2023
7014833
Ignoring 4 failing tests temporarily
T-Gro Feb 13, 2023
b3661ab
Merge branch 'main' into skip-failing-readonlyattr-tests
T-Gro Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Build.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@ try {

# Collect output from background jobs
Wait-job $bgJob | out-null
Receive-Job $bgJob
Receive-Job $bgJob
}

if ($testFSharpQA) {
Expand Down
6 changes: 5 additions & 1 deletion tests/fsharp/Compiler/Language/ByrefTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,8 @@ let test () =
(FSharpDiagnosticSeverity.Error, 256, (6, 13, 6, 16), "A value must be mutable in order to mutate the contents or take the address of a value type, e.g. 'let mutable x = ...'")
|]

[<Test>]
[<Test()>]
[<Ignore("Waiting for test to be aligned", Until = "2023-04-01 12:00:00Z")>]
let ``Returning an 'inref<_>' from a property should emit System.Runtime.CompilerServices.IsReadOnlyAttribute on the return type of the signature`` () =
let src =
"""
Expand Down Expand Up @@ -297,6 +298,7 @@ type C() =
|> ignore

[<Test>]
[<Ignore("Waiting for test to be aligned", Until = "2023-04-01 12:00:00Z")>]
let ``Returning an 'inref<_>' from a generic method should emit System.Runtime.CompilerServices.IsReadOnlyAttribute on the return type of the signature`` () =
let src =
"""
Expand All @@ -319,6 +321,7 @@ type C<'T>() =
|> ignore

[<Test>]
[<Ignore("Waiting for test to be aligned", Until = "2023-04-01 12:00:00Z")>]
let ``Returning an 'inref<_>' from an abstract generic method should emit System.Runtime.CompilerServices.IsReadOnlyAttribute on the return type of the signature`` () =
let src =
"""
Expand All @@ -342,6 +345,7 @@ type C<'T>() =
|> ignore

[<Test>]
[<Ignore("Waiting for test to be aligned", Until = "2023-04-01 12:00:00Z")>]
let ``Returning an 'inref<_>' from an abstract property should emit System.Runtime.CompilerServices.IsReadOnlyAttribute on the return type of the signature`` () =
let src =
"""
Expand Down