Revert "Fix parsing interpolated strings with unmatched braces" #14759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 947f2bb.
psfinaki
approved these changes
Feb 16, 2023
|
@vzarytovskii a code fix becomes available with the revert so it looks like it will fix the issue |
|
/backport to release/dev17.5 |
|
Started backporting to release/dev17.5: https://github.com/dotnet/fsharp/actions/runs/4194830849 |
|
@abonie an error occurred while backporting to release/dev17.5, please check the run log for details! Error: @abonie is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=abonie |
|
/backport to release/dev17.5 |
|
Started backporting to release/dev17.5: https://github.com/dotnet/fsharp/actions/runs/4194849533 |
vzarytovskii
approved these changes
Feb 16, 2023
KevinRansom
added a commit
to KevinRansom/fsharp
that referenced
this pull request
Feb 20, 2023
dotnet#14182)" (dotnet#14759)" This reverts commit aa1d1ce.
KevinRansom
added a commit
to KevinRansom/fsharp
that referenced
this pull request
Feb 20, 2023
dotnet#14182)" (dotnet#14759)" This reverts commit aa1d1ce.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #14182, since it causes #14757