-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FSharpType.IsMeasureType #14978
Add FSharpType.IsMeasureType #14978
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, just SurfaceArea for FCS needs to be updated.
Thanks @T-Gro! How the SurfaceArea is updated? |
@alfonsogarciacaro thanks Alfonso :) See also this PR, the contributor was confused just like you are :) Last commits in that PRs do the right thing though. |
Either manually in the respective surfacearea text file (a text description of the public API). $env:TEST_UPDATE_BSL=1
dotnet test tests/FSharp.Compiler.Service.Tests/FSharp.Compiler.Service.Tests.fsproj --filter "SurfaceAreaTest"
dotnet test tests/FSharp.Compiler.Service.Tests/FSharp.Compiler.Service.Tests.fsproj --filter "SurfaceAreaTest" -c Release
|
Thanks for merging and sorry for not updating the surface area myself 😅 |
It looks there are some measure types that don't have type definition, like
Measure.Var
orMeasure.RationalPower
. This makes it impossible to know if the type is a measure from the FCS public API, so this PR exposes a new member for that.