Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return type hints #14998

Merged
merged 14 commits into from
Mar 31, 2023
Merged

Return type hints #14998

merged 14 commits into from
Mar 31, 2023

Conversation

0101
Copy link
Contributor

@0101 0101 commented Mar 29, 2023 •
edited
Loading

#14379

Lambdas are not covered because we use symbols to generate the hints and lambdas don't have a symbol. So that will probably come as a separate PR later.

image

@0101 0101 requested a review from a team as a code owner March 29, 2023 14:54
@vzarytovskii
Copy link
Member

Can you please attach a screenshot of how it looks now in VS?

@0101
Copy link
Contributor Author

0101 commented Mar 29, 2023

Can you please attach a screenshot of how it looks now in VS?

Added to description.

psfinaki
psfinaki reviewed Mar 29, 2023
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add this feature to the telemetry bag.

vsintegration/src/FSharp.Editor/Hints/RoslynAdapter.fs Outdated Show resolved Hide resolved
vsintegration/src/FSharp.Editor/Hints/ReturnTypeHints.fs Outdated Show resolved Hide resolved
vsintegration/src/FSharp.Editor/Hints/ReturnTypeHints.fs Outdated Show resolved Hide resolved
@vzarytovskii vzarytovskii merged commit d598a05 into dotnet:main Mar 31, 2023
vzarytovskii pushed a commit that referenced this pull request Apr 1, 2023
@dotnet-bot @0101 @KevinRansom
Merge main to release/dev17.6 (#15010)
4a25a87 
* Fix parameter name hints crashing with multi-line arguments (#15004)

* Return type hints (#14998)

---------

Co-authored-by: Petr Pokorny <petrpokorny@microsoft.com>
Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>
kant2002 pushed a commit to kant2002/fsharp that referenced this pull request Apr 1, 2023
@0101 @kant2002
Return type hints (dotnet#14998)
14791a1
@allisonchou allisonchou mentioned this pull request Apr 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki left review comments

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@abonie abonie abonie approved these changes

Assignees
No one assigned
Labels
release/17.7
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0101 @vzarytovskii @psfinaki @abonie