Fix setup localization + paths #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarTawfik
changed the title
|
@OmarTawfik, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
| @@ -10,7 +10,8 @@ | |||
| <Import Project="$(SetupRootFolder)\FSharp.Setup.props" /> | |||
|
|
|||
| <PropertyGroup> | |||
| <OutputName>Microsoft.FSharp.SDK</OutputName> | |||
| <OutputName Condition="'$(IsLangPack)' == 'false'">Microsoft.FSharp.SDK.Core</OutputName> | |||
| <OutputName Condition="'$(IsLangPack)' == 'true'">Microsoft.FSharp.SDK.Resources.$(LocaleCode)</OutputName> | |||
There was a problem hiding this comment.
Maybe do Condition="'$(IsLangPack)' == 'true'" and Condition="'$(IsLangPack)' != 'true'" (or is it <> true?) to prevent the case where $(LangPack) is set to "True" or "False" and neither of these conditions takes.
There was a problem hiding this comment.
|
looks good to me. |
added 9 commits
September 12, 2016 11:25
|
@dotnet-bot test this please |
OmarTawfik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Microsoft/fsharp-compiler @brettfo