Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser: recover on unfinished identifiers #15030

Merged
merged 7 commits into from
Apr 12, 2023

Conversation

auduchinok
Copy link
Member

@auduchinok auduchinok commented Apr 5, 2023

Adds lexer recovery for unfinished escaped identifiers, and adds parser recovery for such identifiers.
Also aligns lexer rules for these idents with lexers we have in Rider.

`    // invalid empty identifier, token length is 1
``   // unfinished identifier containing all symbols until the line end
```  // unfinished identifier containing all symbols until the line end
```` // invalid empty identifier, token length is 4

type T() =
    [<Test>]
    member _.````() = () // invalid empty identifier

@auduchinok auduchinok requested a review from a team as a code owner April 5, 2023 12:30
@auduchinok auduchinok changed the title Parser: recover on unfinished identifiers in expressions Parser: recover on unfinished identifiers Apr 5, 2023
@auduchinok auduchinok force-pushed the lexer-unfinishedEscapedIdent branch from dd6bf04 to 13b6879 Compare April 5, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants