Parser: recover on missing types in typed-like expressions #15054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auduchinok
force-pushed
the
parser-synType-expr
branch
from
740fad8 to
e93d23e
Compare
T-Gro
approved these changes
Apr 11, 2023
auduchinok
force-pushed
the
parser-synType-expr
branch
from
e93d23e to
e90ec17
Compare
|
It's ready. |
vzarytovskii
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds recovery for expressions with missing types like
e:,e :>, ande :?>.In some cases type parsing seems to have precedence and subsequent nodes are parsed as unfinished types. That can be improved in both
LexFilterand the parser separately.