preserve ranges in result of UnsolvedTyparsOfModuleDef to help with warnings #15243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarfgp
approved these changes
May 24, 2023
T-Gro
approved these changes
May 29, 2023
|
#13298 is definitely desired, I am for putting this in (even though this particular PR does not have any benefit on its own at the moment) |
psfinaki
approved these changes
May 29, 2023
vzarytovskii
added a commit
that referenced
this pull request
May 31, 2023
* LexFilter: cleanup whitespaces (#15250) * Parser: rewrite tuple expr recovery to allow better items recovery (#15227) * Checker: recover on unknown record fields (#15214) * Make anycpu work correctly on Arm64 (#15234) * Makeanuycpu work correctly on arm64 * Update Microsoft.FSharp.Targets * Fix15254 (#15257) * Deploy only compressed metadata for dotnet sdk implementation (#15230) * compress fsharp for sdk * Update FSharp.DependencyManager.Nuget.fsproj * Parser: more binary expressions recovery (#15255) * Use background CancellableTask in VS instead of async & asyncMaybe (#15187) * wip * iteration * iteration: quickinfo, help context * fantomas * todo * moved tasks to editor project, fixed comment colouring bug * fantomas * Fantomas + PR feedback * Update vsintegration/src/FSharp.Editor/Hints/HintService.fs Co-authored-by: Andrii Chebukin <xperiandri@live.ru> * Revert "Update vsintegration/src/FSharp.Editor/Hints/HintService.fs" This reverts commit bf51b31. --------- Co-authored-by: Andrii Chebukin <xperiandri@live.ru> * Name resolution: actually add reported item when trying to replace (#14772) Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> * Move flatErrors tests from fsharpqa (#15251) * temp * tests * flaterrors * update tests * preserve ranges in result of UnsolvedTyparsOfModuleDef to help with warnings (#15243) * preserve ranges in result of UnsolvedTyparsOfModuleDef to help with warnings * use fallback range only for range0 * pattern match instead of Option.isSome * Add test * Revert "Add test" This reverts commit e05e808. * Make `FSharpReferencedProject` representation public (#15266) * Make FSharpReferencedProject representation public * Update surface area * Fantomas * Fantomas --------- Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> * Fix navigation for external enums, DUs and name resultion for members (#15270) * Update FSharp.Compiler.Service.SurfaceArea.netstandard20.debug.bsl * Add warning when compiler selects among multiple record type candidates, fslang-suggestion 1091 (#15256) * Protect assembly exploration for C# extension members (#15271) * Compute ValInline.Never for externs (#15274) * Compute ValInline.Never for externs --------- Co-authored-by: Eugene Auduchinok <eugene.auduchinok@jetbrains.com> Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com> Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com> Co-authored-by: Andrii Chebukin <xperiandri@live.ru> Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> Co-authored-by: dawe <dawedawe@posteo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to help with #14653 and by that unblocking #13298
Edit:
Currently, it's difficult to show the effect of this PR in a test as it works on very internal things.
But if you debug the following test:
and set a breakpoint on
fsharp/src/Compiler/Checking/FindUnsolved.fs
Line 38 in e8e9aea
you can see the effect.
As already mentioned, this tries to unblock #13298 and makes most sense in combination with that.