Add GetSymbolUsesAtLocation API. #15285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now you can also change the single-case |
T-Gro
reviewed
Jun 5, 2023
T-Gro
approved these changes
Jun 5, 2023
psfinaki
reviewed
Jun 5, 2023
psfinaki
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on the F# Foundation Slack, there are instances when the
GetSymbolUseAtLocationfunction may return multiple correct symbols for a given line and end column. However, it currently only returns the first symbol in a somewhat arbitrary manner.To address this limitation, I believe it would be beneficial to introduce an API that allows developers to filter out the symbol they specifically require, based on custom logic tailored to their use case.
In order to demonstrate the scenarios where this issue can arise, I have included two tests that highlight such situations. At present, the only available alternative is to retrieve all symbols, which can be quite inconvenient, particularly for larger files.