Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flag for obj-inference diagnostic #15315

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Add feature flag for obj-inference diagnostic #15315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f782fb5
Add feature flag for obj-inference diagnostic
Smaug123 Jun 5, 2023
c89c305
FSI
Smaug123 Jun 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Compiler/FSComp.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1694,4 +1694,5 @@ featureEscapeBracesInFormattableString,"Escapes curly braces before calling Form
3563,lexInvalidIdentifier,"This is not a valid identifier"
3564,parsMissingUnionCaseName,"Missing union case name"
3565,parsExpectingType,"Expecting type"
featureInformationalObjInferenceDiagnostic,"Diagnostic 3559 (warn when obj inferred) at informational level, off by default"
3566,tcMultipleRecdTypeChoice,"Multiple type matches were found:\n%s\nThe type '%s' was used. Due to the overlapping field names\n%s\nconsider using type annotations or change the order of open statements."
3 changes: 3 additions & 0 deletions src/Compiler/Facilities/LanguageFeatures.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ type LanguageFeature =
| ExtendedStringInterpolation
| WarningWhenMultipleRecdTypeChoice
| ImprovedImpliedArgumentNames
| DiagnosticForObjInference

/// LanguageVersion management
type LanguageVersion(versionText) =
Expand Down Expand Up @@ -161,6 +162,7 @@ type LanguageVersion(versionText) =
LanguageFeature.ExtendedStringInterpolation, previewVersion
LanguageFeature.WarningWhenMultipleRecdTypeChoice, previewVersion
LanguageFeature.ImprovedImpliedArgumentNames, previewVersion
LanguageFeature.DiagnosticForObjInference, previewVersion
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity, this precise line should probably not have gone in during this pull request, since the feature was not actually implemented yet.


]

Expand Down Expand Up @@ -285,6 +287,7 @@ type LanguageVersion(versionText) =
| LanguageFeature.ExtendedStringInterpolation -> FSComp.SR.featureExtendedStringInterpolation ()
| LanguageFeature.WarningWhenMultipleRecdTypeChoice -> FSComp.SR.featureWarningWhenMultipleRecdTypeChoice ()
| LanguageFeature.ImprovedImpliedArgumentNames -> FSComp.SR.featureImprovedImpliedArgumentNames ()
| LanguageFeature.DiagnosticForObjInference -> FSComp.SR.featureInformationalObjInferenceDiagnostic ()

/// Get a version string associated with the given feature.
static member GetFeatureVersionString feature =
Expand Down
1 change: 1 addition & 0 deletions src/Compiler/Facilities/LanguageFeatures.fsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ type LanguageFeature =
| ExtendedStringInterpolation
| WarningWhenMultipleRecdTypeChoice
| ImprovedImpliedArgumentNames
| DiagnosticForObjInference

/// LanguageVersion management
type LanguageVersion =
Expand Down
5 changes: 5 additions & 0 deletions src/Compiler/xlf/FSComp.txt.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,11 @@
<target state="translated">Notace expr[idx] pro indexování a vytváření řezů</target>
<note />
</trans-unit>
<trans-unit id="featureInformationalObjInferenceDiagnostic">
<source>Diagnostic 3559 (warn when obj inferred) at informational level, off by default</source>
<target state="new">Diagnostic 3559 (warn when obj inferred) at informational level, off by default</target>
<note />
</trans-unit>
<trans-unit id="featureInitProperties">
<source>support for consuming init properties</source>
<target state="translated">podpora využívání vlastností init</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Compiler/xlf/FSComp.txt.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,11 @@
<target state="translated">expr[idx]-Notation zum Indizieren und Aufteilen</target>
<note />
</trans-unit>
<trans-unit id="featureInformationalObjInferenceDiagnostic">
<source>Diagnostic 3559 (warn when obj inferred) at informational level, off by default</source>
<target state="new">Diagnostic 3559 (warn when obj inferred) at informational level, off by default</target>
<note />
</trans-unit>
<trans-unit id="featureInitProperties">
<source>support for consuming init properties</source>
<target state="translated">Unterstützung für die Nutzung von Initialisierungseigenschaften</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Compiler/xlf/FSComp.txt.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,11 @@
<target state="translated">Notación para indexación y segmentación expr[idx]</target>
<note />
</trans-unit>
<trans-unit id="featureInformationalObjInferenceDiagnostic">
<source>Diagnostic 3559 (warn when obj inferred) at informational level, off by default</source>
<target state="new">Diagnostic 3559 (warn when obj inferred) at informational level, off by default</target>
<note />
</trans-unit>
<trans-unit id="featureInitProperties">
<source>support for consuming init properties</source>
<target state="translated">compatibilidad con el consumo de propiedades init</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Compiler/xlf/FSComp.txt.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,11 @@
<target state="translated">Notation expr[idx] pour l’indexation et le découpage</target>
<note />
</trans-unit>
<trans-unit id="featureInformationalObjInferenceDiagnostic">
<source>Diagnostic 3559 (warn when obj inferred) at informational level, off by default</source>
<target state="new">Diagnostic 3559 (warn when obj inferred) at informational level, off by default</target>
<note />
</trans-unit>
<trans-unit id="featureInitProperties">
<source>support for consuming init properties</source>
<target state="translated">prise en charge de la consommation des propriétés init</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Compiler/xlf/FSComp.txt.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,11 @@
<target state="translated">Notazione expr[idx] per l'indicizzazione e il sezionamento</target>
<note />
</trans-unit>
<trans-unit id="featureInformationalObjInferenceDiagnostic">
<source>Diagnostic 3559 (warn when obj inferred) at informational level, off by default</source>
<target state="new">Diagnostic 3559 (warn when obj inferred) at informational level, off by default</target>
<note />
</trans-unit>
<trans-unit id="featureInitProperties">
<source>support for consuming init properties</source>
<target state="translated">supporto per l'utilizzo delle proprietà init</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Compiler/xlf/FSComp.txt.ja.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,11 @@
<target state="translated">インデックス作成とスライス用の expr[idx] 表記</target>
<note />
</trans-unit>
<trans-unit id="featureInformationalObjInferenceDiagnostic">
<source>Diagnostic 3559 (warn when obj inferred) at informational level, off by default</source>
<target state="new">Diagnostic 3559 (warn when obj inferred) at informational level, off by default</target>
<note />
</trans-unit>
<trans-unit id="featureInitProperties">
<source>support for consuming init properties</source>
<target state="translated">init プロパティの使用のサポート</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Compiler/xlf/FSComp.txt.ko.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,11 @@
<target state="translated">인덱싱 및 슬라이싱을 위한 expr[idx] 표기법</target>
<note />
</trans-unit>
<trans-unit id="featureInformationalObjInferenceDiagnostic">
<source>Diagnostic 3559 (warn when obj inferred) at informational level, off by default</source>
<target state="new">Diagnostic 3559 (warn when obj inferred) at informational level, off by default</target>
<note />
</trans-unit>
<trans-unit id="featureInitProperties">
<source>support for consuming init properties</source>
<target state="translated">init 속성 사용 지원</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Compiler/xlf/FSComp.txt.pl.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,11 @@
<target state="translated">notacja wyrażenia expr[idx] do indeksowania i fragmentowania</target>
<note />
</trans-unit>
<trans-unit id="featureInformationalObjInferenceDiagnostic">
<source>Diagnostic 3559 (warn when obj inferred) at informational level, off by default</source>
<target state="new">Diagnostic 3559 (warn when obj inferred) at informational level, off by default</target>
<note />
</trans-unit>
<trans-unit id="featureInitProperties">
<source>support for consuming init properties</source>
<target state="translated">obsługa używania właściwości init</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Compiler/xlf/FSComp.txt.pt-BR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,11 @@
<target state="translated">notação expr[idx] para indexação e fatia</target>
<note />
</trans-unit>
<trans-unit id="featureInformationalObjInferenceDiagnostic">
<source>Diagnostic 3559 (warn when obj inferred) at informational level, off by default</source>
<target state="new">Diagnostic 3559 (warn when obj inferred) at informational level, off by default</target>
<note />
</trans-unit>
<trans-unit id="featureInitProperties">
<source>support for consuming init properties</source>
<target state="translated">suporte para consumir propriedades de inicialização</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Compiler/xlf/FSComp.txt.ru.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,11 @@
<target state="translated">expr[idx] для индексации и среза</target>
<note />
</trans-unit>
<trans-unit id="featureInformationalObjInferenceDiagnostic">
<source>Diagnostic 3559 (warn when obj inferred) at informational level, off by default</source>
<target state="new">Diagnostic 3559 (warn when obj inferred) at informational level, off by default</target>
<note />
</trans-unit>
<trans-unit id="featureInitProperties">
<source>support for consuming init properties</source>
<target state="translated">поддержка использования свойств инициализации</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Compiler/xlf/FSComp.txt.tr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,11 @@
<target state="translated">Dizin oluşturma ve dilimleme için expr[idx] gösterimi</target>
<note />
</trans-unit>
<trans-unit id="featureInformationalObjInferenceDiagnostic">
<source>Diagnostic 3559 (warn when obj inferred) at informational level, off by default</source>
<target state="new">Diagnostic 3559 (warn when obj inferred) at informational level, off by default</target>
<note />
</trans-unit>
<trans-unit id="featureInitProperties">
<source>support for consuming init properties</source>
<target state="translated">başlatma özelliklerini kullanma desteği</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Compiler/xlf/FSComp.txt.zh-Hans.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,11 @@
<target state="translated">用于索引和切片的 expr[idx] 表示法</target>
<note />
</trans-unit>
<trans-unit id="featureInformationalObjInferenceDiagnostic">
<source>Diagnostic 3559 (warn when obj inferred) at informational level, off by default</source>
<target state="new">Diagnostic 3559 (warn when obj inferred) at informational level, off by default</target>
<note />
</trans-unit>
<trans-unit id="featureInitProperties">
<source>support for consuming init properties</source>
<target state="translated">支持使用 init 属性</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Compiler/xlf/FSComp.txt.zh-Hant.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,11 @@
<target state="translated">用於編製索引和分割的 expr[idx] 註釋</target>
<note />
</trans-unit>
<trans-unit id="featureInformationalObjInferenceDiagnostic">
<source>Diagnostic 3559 (warn when obj inferred) at informational level, off by default</source>
<target state="new">Diagnostic 3559 (warn when obj inferred) at informational level, off by default</target>
<note />
</trans-unit>
<trans-unit id="featureInitProperties">
<source>support for consuming init properties</source>
<target state="translated">支援使用 init 屬性</target>
Expand Down